Skip non-existing directory when watching for changes

Fix quarkusio#32092. The issue was not specific to Gradle. It was problematic with Gradle, as it was configuring the watcher on not existing directories.
DavideD · Nov 27, 2023 · a7d2f27 · a7d2f27
1 parent 8da8f6b
commit a7d2f27
Showing 1 changed file with 17 additions and 12 deletions.
diff --git a/core/deployment/src/main/java/io/quarkus/deployment/util/FSWatchUtil.java b/core/deployment/src/main/java/io/quarkus/deployment/util/FSWatchUtil.java
@@ -52,20 +52,25 @@ private void doObserve(Collection<Watcher> watchers, long intervalMs) {
             for (Watcher watcher : watchers) {
                 try {
                     Path rootPath = watcher.rootPath;
-                    List<Path> matchingPaths = Files.walk(rootPath)
-                            .filter(path -> hasExtension(path, watcher.fileExtension))
-                            .collect(Collectors.toList());
-                    List<Path> changedFiles = new ArrayList<>();
-                    for (Path path : matchingPaths) {
-                        long lastModifiedTime = Files.getLastModifiedTime(path).toMillis();
-                        if (lastModifiedTime > lastModified.computeIfAbsent(path, whatever -> 0L)) {
-                            changedFiles.add(path);
-                            lastModified.put(path, lastModifiedTime);
-                        }
+                    if (!rootPath.toFile().isDirectory()) {
+                        // Skip directory - it does not exist.
+                        continue;
                     }
 
-                    if (!firstRun && !changedFiles.isEmpty()) {
-                        watcher.action.accept(changedFiles);
+                    try (var walker = Files.walk(rootPath)) {
+                        List<Path> matchingPaths = walker.filter(path -> hasExtension(path, watcher.fileExtension))
+                                .collect(Collectors.toList());
+                        List<Path> changedFiles = new ArrayList<>();
+                        for (Path path : matchingPaths) {
+                            long lastModifiedTime = Files.getLastModifiedTime(path).toMillis();
+                            if (lastModifiedTime > lastModified.computeIfAbsent(path, whatever -> 0L)) {
+                                changedFiles.add(path);
+                                lastModified.put(path, lastModifiedTime);
+                            }
+                        }
+                        if (!firstRun && !changedFiles.isEmpty()) {
+                            watcher.action.accept(changedFiles);
+                        }
                     }
                 } catch (IOException e) {
                     log.debug("Failed checking for code gen source modifications", e);