Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forked repository. #1

Merged
merged 106 commits into from
May 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
6b0ebea
(dagster-api-3) Add api execute pipeline command
helloworld May 7, 2020
bdd564d
Convert dep_dsl to full example
helloworld May 18, 2020
f00b240
Fix pipeline name in dep_dsl pipeline
helloworld May 18, 2020
f965380
FilesytemTestScheduler -> FilesystemTestScheduler
schrockn May 18, 2020
5396296
Remove repository definition from ScheduleExecutionContext
helloworld May 18, 2020
8a3796a
Replace more calls to get_repository_definition with get_external_rep…
helloworld May 18, 2020
b62fa44
Add query to get runs grouped by root run id
mgasner May 18, 2020
701114c
GraphQL query for run groupings
mgasner May 18, 2020
30ca1be
Add tooltip for disabled re-executions
mgasner May 18, 2020
655169e
Fix issue number
schrockn May 18, 2020
97bcefe
[dagit] enable multi-step re-execution via step subset selector #2453
yuhan May 15, 2020
f7cdf4c
dagit run viewer - step text label unselectable #2471
yuhan May 18, 2020
c466ece
Update serdes.ipc tests to use safe_tempfile
helloworld May 19, 2020
c4ecbc1
More spelling fixes
schrockn May 19, 2020
196cfee
[0.8.0] delete schedules & partitions handles
alangenfeld May 14, 2020
7984252
(execute-pipeline-out-of-process-1) Add top level functions to invoke…
schrockn May 18, 2020
96214bf
(execute-pipeline-out-of-process-2) Allow passing of instance-ref to cli
schrockn May 18, 2020
149bfef
(execute-pipeline-out-of-process-4) Move CodePointer classes in dagst…
schrockn May 19, 2020
eecf79d
Fix dagster pipeline {command_name} instructions
May 17, 2020
f10d371
(multi-1) multi-env multi-repo DagsterGraphQLContext
alangenfeld May 18, 2020
50a7f30
clean up console.log
yuhan May 18, 2020
76f6f9a
Initial version of wider, pipeline-centric left sidebar
bengotow May 18, 2020
5c6b8e6
Add error handling for get_or_create_run race condition
Apr 29, 2020
643f1e7
lay ExecutionSelector to rest
alangenfeld May 19, 2020
ede61a5
make sure menu items are each on their own line
prha May 19, 2020
3b99111
Extract create_db_conn_string
schrockn May 19, 2020
36340d5
[docs] move small examples out of dagster_examples
yuhan May 20, 2020
81c707d
Add create example command
helloworld May 20, 2020
2657a3d
[docs] Deprecate RTD -- add meta refresh to redirect to new site
yuhan May 20, 2020
6de136b
Fix invalid config schedule execution
helloworld May 19, 2020
55556d0
Fix dagster_type auto_plugins arg type in doc
May 19, 2020
6912488
Formalize dagit "pipeline scope" with "Overview", "Definition", "Play…
bengotow May 19, 2020
3b6c7f4
Create pipeline overview landing page
prha May 19, 2020
dd7883b
(dagster-cli-api-run-launcher-1) Move RunLauncher to base.py
schrockn May 20, 2020
08302e4
"Stream" events from S3 to plan process
May 20, 2020
e44a6fe
Fix ipc windows errors
helloworld May 20, 2020
1aeeaf3
(multi-2) selector and handle
alangenfeld May 20, 2020
d353863
RFC - a way to run multiproc engine without sqlite event log
alangenfeld May 14, 2020
eda7c78
(dagster-cli-api-run-launcher-2) Add cli api for execute_run
schrockn May 20, 2020
395d0a1
Delete all non *orError accessors
prha May 20, 2020
890c7e6
Consolidate ReconstructablePipeline and ReconstructablePipelineFromRe…
schrockn May 21, 2020
f3c7534
Delete execute_pipeline in cli api
schrockn May 20, 2020
f282d5b
"Stream" events from EMR to S3
May 21, 2020
0468179
Remove graphviz from dagster core
May 21, 2020
dac22fa
Delete container-based loading for now
schrockn May 21, 2020
a2431ab
Fix spelling errors in serdes
schrockn May 20, 2020
bd82e89
(run-launcher-handle-aware-1) Move ReconstructableRepository.from_yam…
schrockn May 21, 2020
0371ec7
(run-launcher-handle-aware-2) [testing] Add InProcessOrigin (pointer …
schrockn May 21, 2020
5a29a98
(run-launcher-handle-aware-3) Add optional external_pipeline argument…
schrockn May 21, 2020
b61809e
Fix k8s run launcher bug
May 21, 2020
69c5702
Add Airflow issue comment
schrockn May 21, 2020
da56c12
Rename get_or_create_run() => register_managed_run() and other clean up
May 19, 2020
9d8af2c
limit runs, add typeahead on root page, removed dropdown selector
prha May 20, 2020
8fb4af0
Fix master
May 21, 2020
452043a
Add CliApiRunLauncher [redux]
schrockn May 20, 2020
83d8f4b
[docs] deploy 1/ update version script
yuhan May 21, 2020
9c87ffb
bump doc versions
yuhan May 22, 2020
97e6804
Dauphin spelling
schrockn May 21, 2020
9abd82b
Delete schedule attempts
helloworld May 22, 2020
be13b8b
[docs] deploy 2/ convert versions page to json and update script
yuhan May 22, 2020
350940b
Clarify behavior when a schedule with a given name is not found in a …
mgasner May 22, 2020
ca194f3
1/ Add helpers to get cli args from reconstructables
mgasner May 22, 2020
26a712c
[dagit] make log filter follow the step selection DSL #2472
yuhan May 22, 2020
988cd59
Fix expectations misspelling
schrockn May 22, 2020
51c5fae
(dagster-cli-api-run-launcher-4) Add engine events to the cli codepath
schrockn May 20, 2020
6626cb1
(dagster-cli-api-run-launcher-5) Make subset execution work over cli api
schrockn May 21, 2020
efe401a
(dagster-cli-api-run-launcher-5.5) Revamp dagster-graphql scheduler t…
schrockn May 22, 2020
3380abb
(dagster-cli-api-run-launcher-6) Make cli api run launcher configurab…
schrockn May 22, 2020
9f3c9fe
(dagster-cli-api-run-launcher-7) Add APIs to RunLauncher for terminat…
schrockn May 21, 2020
faf43c9
Fix windows errors temporarily by silencing errors
schrockn May 22, 2020
b5d856c
Fix lint error
schrockn May 22, 2020
0d47635
Add repo stats to telemetry
May 17, 2020
248c63f
run grouping - persist step selection query in tags
yuhan May 22, 2020
48f20b5
[dagit] shift-click to multi select steps #2470
yuhan May 22, 2020
c1dd529
fix sqlite temporary file vs TemporaryDirectory cleanup race
alangenfeld May 24, 2020
16fb929
Add support for dask clusters (#2498)
DavidKatz-il May 26, 2020
ebedd72
[dagster-graphql] rename cancel to terminate
alangenfeld May 24, 2020
52bb489
[dagit] launched run termination
alangenfeld May 24, 2020
5ab6d4a
(graphql-context-test-suite-1) Move queries to composites_queries
schrockn May 23, 2020
59f9c78
(graphql-context-test-suite-2) Add graphql_context_test_suite
schrockn May 23, 2020
f11074c
2/ Add description field to RepositoryDefinition
mgasner May 26, 2020
79d37d1
Implements Flyte Type System mapping
jbrambleDC May 25, 2020
0128272
(graphql-context-test-suite-4) Move test_run_cancellation.py to be gr…
schrockn May 23, 2020
09db3e5
(graphql-context-test-suite-5) Move a couple tests in test_execute_pi…
schrockn May 23, 2020
3bf2a8d
(graphql-context-test-suite-6) Add SyncInMemoryRunLauncher
schrockn May 23, 2020
684482b
(graphql-context-test-suite-7) Refactor launch to have inner function
schrockn May 23, 2020
c2ceb0f
(graphql-context-test-suite-8) Start to use launch implementation in …
schrockn May 23, 2020
462981a
(graphql-context-test-suite-9) Add hijack_start config to CliApiRunLa…
schrockn May 24, 2020
868d66a
(graphql-context-test-suite-10) Allow execution_manager on environmen…
schrockn May 24, 2020
674b1d2
(graphql-context-test-suite-11) Add hosted user process helpers
schrockn May 24, 2020
994e3c2
(graphql-context-test-suite-12) Add OutOfProcessDagsterEnvironment an…
schrockn May 24, 2020
3562004
(graphql-context-test-suite-13) Move one test over to hijacking start…
schrockn May 25, 2020
6bed558
(graphql-context-test-suite-14) Move some more tests over to the hija…
schrockn May 25, 2020
cb78d02
(graphql-context-test-suite-15) Add a new test suite for legacy tests…
schrockn May 25, 2020
a43202c
(graphql-context-test-suite-16) Move test_compute_logs, test_config_t…
schrockn May 25, 2020
160d6ce
(graphql-context-test-suite-17) Use custom variant to test disabled e…
schrockn May 25, 2020
120d24e
(run-hijacking-1) Add sqlite instance variant with synchronous hijack
schrockn May 25, 2020
325d739
(run-hijacking-2) Extract do_launch_for_created_run from _launch_pipe…
schrockn May 25, 2020
8e5ae08
(run-hijacking-3) Actually to hijack for start with a created run. Ad…
schrockn May 25, 2020
510926f
(run-hijacking-4) Move test_run_launcher to use graphql_context_test_…
schrockn May 25, 2020
ddabb49
(run-hijacking-5) Port test_reexecution.py to graphql context test suite
schrockn May 25, 2020
fbc4f4d
(run-hijacking-6) Make test_reexectution work on all applicable variants
schrockn May 25, 2020
d8cdeca
(run-hijacking-7) Move test_retry_execution.py to test suite
schrockn May 25, 2020
53bf468
(run-hijacking-8) Add hijacking run launcher to test_retry_execution.py
schrockn May 25, 2020
fe744b8
Fix pylint issues with recent pylint
May 27, 2020
7a032d8
bug fix - step selection query in tags
yuhan May 26, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 3 additions & 2 deletions .buildkite/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ def python_modules_tox_tests(directory, supported_pythons=None):
"buildkite-agent artifact upload {file}".format(file=coverage),
)
.on_integration_image(
version, ['AWS_DEFAULT_REGION', 'TWILIO_TEST_ACCOUNT_SID', 'TWILIO_TEST_AUTH_TOKEN']
version,
['AWS_DEFAULT_REGION', 'TWILIO_TEST_ACCOUNT_SID', 'TWILIO_TEST_AUTH_TOKEN',],
)
.build()
)
Expand Down Expand Up @@ -321,7 +322,7 @@ def flyte_tests():
StepBuilder("dagster-flyte tests ({ver})".format(ver=TOX_MAP[version]))
.run(
"pushd python_modules/libraries/dagster-flyte",
"tox -e {ver}".format(ver=TOX_MAP[version]),
"tox -vv -e {ver}".format(ver=TOX_MAP[version]),
"mv .coverage {file}".format(file=coverage),
"buildkite-agent artifact upload {file}".format(file=coverage),
)
Expand Down
9 changes: 9 additions & 0 deletions .gitpod.Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
FROM gitpod/workspace-full

USER gitpod

# Install wxPython dependencies
RUN sudo apt-get -q update

ENV DAGSTER_HOME="$HOME/dagster_home"
RUN mkdir -p $DAGSTER_HOME
16 changes: 16 additions & 0 deletions .gitpod.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
image:
file: .gitpod.Dockerfile

# This will expose all necessary ports needed for your VNC image
ports:
- port: 3000
onOpen: open-preview

tasks:
- command: |
cd examples/$EXAMPLE
pip3 install -r requirements.txt
[ -e README.md ] && gp open README.md
clear && dagit
- openMode: split-right
command: echo SplitTerminal && clear
3 changes: 2 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@
# C - convention related checks
# W0511 disable TODO warning
# W1201, W1202 disable log format warning. False positives (I think)
# W0231 disable super-init-not-called - pylint doesn't understand six.with_metaclass(ABCMeta)

disable=C,R,duplicate-code,W0511,W1201,W1202,no-init
disable=C,R,duplicate-code,W0231,W0511,W1201,W1202,no-init

# See: https://github.com/getsentry/responses/issues/74
[TYPECHECK]
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
- The CLI option `--celery-base-priority` is no longer available for the command:
`dagster pipeline backfill`. Use the tags option to specify the celery priority, (e.g.
`dagster pipeline backfill my_pipeline --tags '{ "dagster-celery/run_priority": 3 }'`
- The `ScheduleExecutionContext` no longer has a repository definition available as a property on the context. If you were previously using it in a schedule definition, inline the repository name instead of retrieving it from the schedule execution context.
- `@scheduler` and `@repository_partitions` have been removed. Load `ScheduleDefinition`s and `PartitionSetDefinition`s via `RepositoryDefinition` instead.

## 0.7.13

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ install_dev_python_modules:
-pip install -e examples[full] $(QUIET)

# NOTE: This installation will fail for Python 2.7 (Dask doesn't work w/ py27 on macOS)
-pip install -e python_modules/libraries/dagster-dask $(QUIET)
-pip install -e "python_modules/libraries/dagster-dask[yarn,pbs,kube]" $(QUIET)

# This fails on py2
-pip install -r .read-the-docs-requirements.txt
Expand Down
23 changes: 23 additions & 0 deletions bin/assets/dagster-example-tmpl/README.md.tmpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
title: {{EXAMPLE_NAME}}
description: Fill in a description
---

# {{EXAMPLE_NAME}}

Description of example goes here

# Open in Playground

Open up this example in a playground using [Gitpod](https://gitpod.io)

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#EXAMPLE={{EXAMPLE_NAME}}/https://github.com/dagster-io/dagster)

# Download Manually

Download the example:

```
curl https://codeload.github.com/dagster-io/dagster/tar.gz/master | tar -xz --strip=2 dagster-master/examples/{{EXAMPLE_NAME}}
cd dep_dsl
```
15 changes: 15 additions & 0 deletions bin/assets/dagster-example-tmpl/repo.py.tmpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
from dagster import RepositoryDefinition, pipeline, solid


@solid
def hello(_):
return 1


@pipeline
def my_pipeline():
hello()


def define_repository():
return RepositoryDefinition("{{EXAMPLE_NAME}}", pipeline_defs=[my_pipeline])
3 changes: 3 additions & 0 deletions bin/assets/dagster-example-tmpl/repository.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
repository:
file: repo.py
fn: define_repository
2 changes: 2 additions & 0 deletions bin/assets/dagster-example-tmpl/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
dagster
dagit
67 changes: 67 additions & 0 deletions bin/create_example.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
#!/usr/bin/env python3

"""
To use, run
python bin/create_example.py --name example_name
"""
from __future__ import absolute_import

import os
import shutil
import sys

import click

BASE_PATH = os.path.dirname(os.path.realpath(__file__))
sys.path.insert(0, BASE_PATH)

from git_utils import get_most_recent_git_tag # isort:skip


def copy_directory(src, dest):
try:
shutil.copytree(src, dest, ignore=shutil.ignore_patterns('.DS_Store'))
# Directories are the same
except shutil.Error as e:
print('Directory not copied. Error: %s' % e)
# Any error saying that the directory doesn't exist
except OSError as e:
print('Directory not copied. Error: %s' % e)


@click.command()
@click.option('--name', prompt='Name of library', help='Name of library')
def main(name):
template_library_path = os.path.abspath('bin/assets/dagster-example-tmpl')
new_template_library_path = os.path.abspath('examples/{name}'.format(name=name))

if os.path.exists(new_template_library_path):
raise click.UsageError('Example with name {name} already exists'.format(name=name))

copy_directory(template_library_path, new_template_library_path)

version = get_most_recent_git_tag()

for dname, _, files in os.walk(new_template_library_path):
for fname in files:
fpath = os.path.join(dname, fname)
with open(fpath) as f:
s = f.read()
s = s.replace('{{EXAMPLE_NAME}}', name)
s = s.replace('{{VERSION}}', version)
with open(fpath, 'w') as f:
f.write(s)

new_fname = fname.replace('.tmpl', '')
new_fpath = os.path.join(dname, new_fname)
shutil.move(fpath, new_fpath)
print('Created {path}'.format(path=new_fpath))

new_dname = dname.replace('example-tmpl', name)
shutil.move(dname, new_dname)

print('Example created at {path}'.format(path=new_template_library_path))


if __name__ == "__main__":
main() # pylint: disable=no-value-for-parameter
3 changes: 1 addition & 2 deletions bin/dagster_module_publisher.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def check_for_cruft(self, autoclean):

found_pyc_files = []

for root, dir_, files in os.walk(git_repo_root()):
for root, _, files in os.walk(git_repo_root()):
for file_ in files:
if file_.endswith('.pyc'):
found_pyc_files.append(os.path.join(root, file_))
Expand Down Expand Up @@ -136,7 +136,6 @@ def check_directory_structure(self):
expected_modules_not_found = []

module_directories = get_core_module_directories()
library_directories = get_library_module_directories()

for module_dir in module_directories:
if module_dir.name not in expected_python_modules_subdirectories:
Expand Down
4 changes: 2 additions & 2 deletions docs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ buildnext:
NODE_ENV=$(or $(NODE_ENV), development) yarn --cwd next sitemap

root_build:
NODE_ENV=production make build_next_default version=0.7.12
NODE_ENV=production make build_next_version version=0.7.12
NODE_ENV=production make build_next_default version=0.7.14
NODE_ENV=production make build_next_version version=0.7.14

build_next_master:
yarn --cwd next --production=false
Expand Down
18 changes: 3 additions & 15 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,11 @@ linkchecker http://127.0.0.1:8000
NODE_ENV=production make buildnext
```

2. Update version links in `next/src/pages/versions/index.mdx` such as (replace `<new_version>` with e.g. `0.7.12`):
2. Update version links in `next/src/pages/versions/index.mdx`, run:

```
# Dagster Versions

## Current version (Stable)

| **<new_version>** | [Documentation](/docs/install) | [Release Notes](https://github.com/dagster-io/dagster/releases/tag/<new_version>) |
| ----------- | ------------------------------------- | --------------------------------------------------------------------------- | --------------------------------------- |


## All Versions

| **<new_version>** | [Documentation](/<new_version>/docs/install) | [Release Notes](https://github.com/dagster-io/dagster/releases/tag/<new_version>) | |
| ----------- | ------------------------------------- | --------------------------------------------------------------------------- | --------------------------------------- |
| **0.7.11** | [Documentation](/0.7.11/docs/install) | [Release Notes](https://github.com/dagster-io/dagster/releases/tag/0.7.11) | |
| **0.7.10** | [Documentation](/0.7.10/docs/install) | [Release Notes](https://github.com/dagster-io/dagster/releases/tag/0.7.10) | |
cd next
yarn update-version <new_version> # e.g. `yarn update-version 0.7.12`
```

3. Build the static doc site by running `make root_build` in the `docs` directory. It will generate a folder called `out` in the `docs` directory.
Expand Down
Loading