Move gatherer and repr/eq hiding logic into core - various logic bugfixes #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add attribute_gatherer logic to core
Make Field rely on unified_gatherer instead of slot_gatherer. Metaclass now does the same gathering work as regular classes, but puts all of the detail in __slots__.
Make sure get_annotations always returns a copy.
Rename get_annotations to get_ns_annotations to be clear it's for class namespaces.
* Make GatheredFields a slotclass * return SlotMakerMeta metaclass to Field again. * fix some type hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move more logic out of Prefab and into core.
Fix potential infinite loops in get_ns_annotations.
Simplification of Field and GatheredField generated elements.