Expand the build_prefab function #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add slots option to build_prefab Use GatheredFields in build_prefab to skip searching for fields that have just been put in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_prefabnow skips the gathering stage of@prefabas the values are provided, it will still set__annotations__as expected.It also now has a
slotsargument which can be used to create classes that use slots. This argument will not exist in the standardprefab(...)call as slots support is provided by declaring the class using__slots__ = SlotFields(...)rather than by an argument toprefab.As an internal change there is now a
GatheredFieldsclass in the core which is used to provide tobuildera callable that returns previously gathered fields and modifications. This is now used to add the additional methods toFieldandGatheredFieldsitself.