Merge pull request #30 from DavidCEllis/relax_init_kw_only

Allow for attributes to be both kw_only and not in init.
DavidCEllis · Nov 5, 2024 · eac5657 · eac5657
2 parents 6910b40 + 6e1dfff
commit eac5657
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 20 deletions.
diff --git a/src/ducktools/classbuilder/__init__.py b/src/ducktools/classbuilder/__init__.py
@@ -654,11 +654,6 @@ def validate_field(self):
                 f"{cls_name} cannot define both a default value and a default factory."
             )
 
-        if self.kw_only and not self.init:
-            raise AttributeError(
-                f"{cls_name} cannot be keyword only if it is not in init."
-            )
-
     @classmethod
     def from_field(cls, fld, /, **kwargs):
         """

diff --git a/tests/prefab/shared/examples/fails/creation_1.py b/tests/prefab/shared/examples/fails/creation_1.py
diff --git a/tests/prefab/shared/test_creation.py b/tests/prefab/shared/test_creation.py
@@ -144,15 +144,6 @@ def test_skipped_annotated_classvars(self):
 
 
 class TestExceptions:
-    def test_kw_not_in_init(self):
-        with pytest.raises(AttributeError) as e_info:
-            from fails.creation_1 import Construct
-
-        assert (
-            e_info.value.args[0]
-            == "Attribute cannot be keyword only if it is not in init."
-        )
-
     def test_positional_after_kw_error(self):
         with pytest.raises(SyntaxError) as e_info:
             from fails.creation_2 import FailSyntax