Update MD054/link-image-style to handle autolinked email addresses wh…

…en disallowed (fixes #1391).
DavidAnson · Oct 28, 2024 · a7a50ea · a7a50ea
1 parent 3b07268
commit a7a50ea
Show file tree

Hide file tree

Showing 16 changed files with 866 additions and 12 deletions.
diff --git a/demo/markdownlint-browser.js b/demo/markdownlint-browser.js
@@ -6721,9 +6721,9 @@ module.exports = {
       let isError = false;
       if (type === "autolink") {
         // link kind is an autolink
-        destination = getDescendantsByType(link, [ "autolinkProtocol" ])[0].text;
+        destination = getDescendantsByType(link, [ [ "autolinkEmail", "autolinkProtocol" ] ])[0]?.text;
         label = destination;
-        isError = !autolink;
+        isError = !autolink && Boolean(destination);
       } else {
         // link type is "image" or "link"
         label = getDescendantsByType(link, [ "label", "labelText" ])[0].text;

diff --git a/lib/md054.js b/lib/md054.js
@@ -51,9 +51,9 @@ module.exports = {
       let isError = false;
       if (type === "autolink") {
         // link kind is an autolink
-        destination = getDescendantsByType(link, [ "autolinkProtocol" ])[0].text;
+        destination = getDescendantsByType(link, [ [ "autolinkEmail", "autolinkProtocol" ] ])[0]?.text;
         label = destination;
-        isError = !autolink;
+        isError = !autolink && Boolean(destination);
       } else {
         // link type is "image" or "link"
         label = getDescendantsByType(link, [ "label", "labelText" ])[0].text;

diff --git a/test/link-style-autolink-only.md b/test/link-style-autolink-only.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text
 
 Text [url](https://example.com/an>g<le>) text {MD054}
 
+Text <[email protected]> text
+
+Text [[email protected]]([email protected]) text {MD054}
+
+Text [[email protected]][email] text {MD054}
+
+Text [email][] text {MD054}
+
+Text [email] text {MD054}
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-reference-definitions": false,

diff --git a/test/link-style-autolink-or-inline.md b/test/link-style-autolink-or-inline.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text
 
 Text [url](https://example.com/an>g<le>) text
 
+Text <[email protected]> text
+
+Text [[email protected]]([email protected]) text
+
+Text [[email protected]][email] text {MD054}
+
+Text [email][] text {MD054}
+
+Text [email] text {MD054}
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-reference-definitions": false,

diff --git a/test/link-style-autolink-or-reference.md b/test/link-style-autolink-or-reference.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text
 
 Text [url](https://example.com/an>g<le>) text {MD054}
 
+Text <[email protected]> text
+
+Text [[email protected]]([email protected]) text {MD054}
+
+Text [[email protected]][email] text
+
+Text [email][] text
+
+Text [email] text
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-style": {

diff --git a/test/link-style-collapsed-only.md b/test/link-style-collapsed-only.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text {MD054}
 
 Text [url](https://example.com/an>g<le>) text {MD054}
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected]) text {MD054}
+
+Text [[email protected]][email] text {MD054}
+
+Text [email][] text
+
+Text [email] text {MD054}
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-style": {

diff --git a/test/link-style-full-only.md b/test/link-style-full-only.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text {MD054}
 
 Text [url](https://example.com/an>g<le>) text {MD054}
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected]) text {MD054}
+
+Text [[email protected]][email] text
+
+Text [email][] text {MD054}
+
+Text [email] text {MD054}
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-style": {

diff --git a/test/link-style-inline-only.md b/test/link-style-inline-only.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text {MD054}
 
 Text [url](https://example.com/an>g<le>) text
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected])
+
+Text [[email protected]][email] text {MD054}
+
+Text [email][] text {MD054}
+
+Text [email] text {MD054}
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-reference-definitions": false,

diff --git a/test/link-style-inline-or-reference.md b/test/link-style-inline-or-reference.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text {MD054}
 
 Text [url](https://example.com/an>g<le>) text
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected]) text
+
+Text [[email protected]][email] text
+
+Text [email][] text
+
+Text [email] text
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-style": {

diff --git a/test/link-style-no-url-inline-not-possible.md b/test/link-style-no-url-inline-not-possible.md
@@ -47,6 +47,18 @@ Text ![url] text
 
 Text [file.md](file.md) text
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected]) text
+
+Text [[email protected]][email] text
+
+Text [email][] text
+
+Text [email] text
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-image-style": {
     "autolink": false,

diff --git a/test/link-style-no-url-inline-possible.md b/test/link-style-no-url-inline-possible.md
@@ -47,6 +47,19 @@ Text ![url] text
 
 Text [file.md](file.md) text
 
+Text <[email protected]> text
+
+Text [[email protected]]([email protected]) text
+(allowed by !url_inline because email address is not an absolute URL)
+
+Text [[email protected]][email] text
+
+Text [email][] text
+
+Text [email] text
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-image-style": {
     "url_inline": false

diff --git a/test/link-style-none.md b/test/link-style-none.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text {MD054}
 
 Text [url](https://example.com/an>g<le>) text {MD054}
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected]) text {MD054}
+
+Text [[email protected]][email] text {MD054}
+
+Text [email][] text {MD054}
+
+Text [email] text {MD054}
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-reference-definitions": false,

diff --git a/test/link-style-reference-only.md b/test/link-style-reference-only.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text {MD054}
 
 Text [url](https://example.com/an>g<le>) text {MD054}
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected]) text {MD054}
+
+Text [[email protected]][email] text
+
+Text [email][] text
+
+Text [email] text
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-style": {

diff --git a/test/link-style-shortcut-only.md b/test/link-style-shortcut-only.md
@@ -68,6 +68,18 @@ Text <https://example.com/pa)re(ns> text {MD054}
 
 Text [url](https://example.com/an>g<le>) text {MD054}
 
+Text <[email protected]> text {MD054}
+
+Text [[email protected]]([email protected]) text {MD054}
+
+Text [[email protected]][email] text {MD054}
+
+Text [email][] text {MD054}
+
+Text [email] text
+
+[email]: [email protected]
+
 <!-- markdownlint-configure-file {
   "link-fragments": false,
   "link-image-style": {