-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade vue-plotly to Vue3 + Vite + TS #53
base: master
Are you sure you want to change the base?
Conversation
Looks like the repo owner is inactive. Could this become a new standalone package? |
I'm afraid you are right. I try to talk with David on LinkedIn without success. :-(
It is ok to me. We can start a team to maintain it. For now, come with PRs and issues to @aurium/vue-plotly We can move this repo to a new group be "less personal". |
@Path-A I believe is that what you want: https://www.npmjs.com/package/@aurium/vue-plotly |
I tried to make a real upgrade, not only a simple translation. So you'll find a lot of changes, but respecting your original concept.
Vue
,@vueuse/core
andPlotly.js
) to the bundle, letting it smaller and enabling users to upgrade these libs to take advantage of improvements and bug fixes.ResizeObserver
fromvueuse
to be responsive.Jest
test runner was replaced byVitest
for a better integration. (And it's really nice!)Plotly.js
instance methods are extracted from its source and exposed by the component instance, with arg types, but the first.Plotly.js
methods and listen for its events.(did I miss something?)