Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade vue-plotly to Vue3 + Vite + TS #53

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

aurium
Copy link

@aurium aurium commented Apr 13, 2023

I tried to make a real upgrade, not only a simple translation. So you'll find a lot of changes, but respecting your original concept.

  • All dependencies are upgraded to newest or replaced by a modern solution.
  • Types are tested and exported by build script to the released package.
  • It publishes only the build and mandatory files.
  • The Vite builder will not include external dependencies (Vue, @vueuse/core and Plotly.js) to the bundle, letting it smaller and enabling users to upgrade these libs to take advantage of improvements and bug fixes.
  • It now uses ResizeObserver from vueuse to be responsive.
  • The Jest test runner was replaced by Vitest for a better integration. (And it's really nice!)
  • The component is written in the Composition API fashion.
  • All Plotly.js instance methods are extracted from its source and exposed by the component instance, with arg types, but the first.
  • The example shows how to access that Plotly.js methods and listen for its events.
    (did I miss something?)

@Path-A
Copy link

Path-A commented Jun 12, 2023

Looks like the repo owner is inactive. Could this become a new standalone package?

@aurium
Copy link
Author

aurium commented Jun 15, 2023

Looks like the repo owner is inactive.

I'm afraid you are right. I try to talk with David on LinkedIn without success. :-(

Could this become a new standalone package?

It is ok to me. We can start a team to maintain it. For now, come with PRs and issues to @aurium/vue-plotly

We can move this repo to a new group be "less personal".

@aurium
Copy link
Author

aurium commented Jun 15, 2023

@Path-A I believe is that what you want: https://www.npmjs.com/package/@aurium/vue-plotly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants