Add config prop #15
Open
Add config prop #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, a config object that might otherwise be passed to `Plotly.setPlotConfig()` or as the last argument to `Plotly.newPlot()`, can be passed to the `Plotly` Vue component. It is still possible to pass individial config props that get merged into the resulting config object, but using the new config prop allows for encapsulation of configuration as well as reuse and may help keep things tidier.
jrtitus
reviewed
Jul 6, 2021
| @@ -22,6 +22,9 @@ export default { | |||
| layout: { | |||
| type: Object | |||
| }, | |||
| config: { | |||
| type: Object | |||
| }, | |||
There was a problem hiding this comment.
Maybe use default: () => {} here instead of having the || {} on line 75?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, a config object that might otherwise be passed to
Plotly.setPlotConfig()or as the last argument toPlotly.newPlot(),can be passed to the
PlotlyVue component. It is still possible topass individial config props that get merged into the resulting config
object, but using the new config prop allows for encapsulation of
configuration as well as reuse and may help keep things tidier.