Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windrose legend overlaps under mobile when using knots [BUG] #249

Closed
nicholaswaton opened this issue Feb 3, 2024 · 3 comments
Closed

Windrose legend overlaps under mobile when using knots [BUG] #249

nicholaswaton opened this issue Feb 3, 2024 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@nicholaswaton
Copy link

Hello

I noticed that because we are using knots, the legend for the windRose overlaps a lot on mobile. Also, seeing "knots" so many times seems redundant.
I was wondering if it would be possible to remove the unit (leaving just the range in numbers)?

This is what I see on mobile:
IMG_3177

I also removed the units from the ticks on Gauges, for a cleaner look but I couldn't figure how to do it on the windRose.
Screenshot 2024-02-03 at 12 48 32

thank you!

@nicholaswaton nicholaswaton added the bug Something isn't working label Feb 3, 2024
@Daveiano
Copy link
Owner

Daveiano commented Feb 6, 2024

Hello!

I noticed that because we are using knots, the legend for the windRose overlaps a lot on mobile. Also, seeing "knots" so many times seems redundant.
I was wondering if it would be possible to remove the unit (leaving just the range in numbers)?

I added a new configuration, windRose_legend_show_units. When set to True, the unit labels are not shown in the legend. Instead, the unit is shown once above the legend:

Screenshot

This should hopefully fix the overlapping text. The new configuration will be included in the next upcoming release!

I also removed the units from the ticks on Gauges, for a cleaner look but I couldn't figure how to do it on the windRose.

May I ask, how you did this? Probably this should be also configurable?

@nicholaswaton
Copy link
Author

That looks great!

For the Gauge, I went in the javascript code in main.js and removed the part where it adds the unit to each tick. It was challenging to find as it was minified, but I figured it out. It would definitely be great if it could be configured.

I love also the new option for the legend position. It was also bothering me as it was often too close to the graphs.

@Daveiano
Copy link
Owner

Daveiano commented Feb 7, 2024

For the Gauge, I went in the javascript code in main.js and removed the part where it adds the unit to each tick. It was challenging to find as it was minified, but I figured it out. It would definitely be great if it could be configured.

Sounds like a bit pain in the... I added hide_tick_unit for configuring this, will be included in 3.5.0, too.

I love also the new option for the legend position. It was also bothering me as it was often too close to the graphs.

Great, happy to hear that!

@Daveiano Daveiano added this to the 3.5.0 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants