Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored Temperature #243

Closed
c0by85 opened this issue Jan 16, 2024 · 15 comments
Closed

Colored Temperature #243

c0by85 opened this issue Jan 16, 2024 · 15 comments
Labels
enhancement New feature or request
Milestone

Comments

@c0by85
Copy link
Contributor

c0by85 commented Jan 16, 2024

Could please add colored Temperature? Like in the Belchertown Skin?

image

@c0by85 c0by85 added the enhancement New feature or request label Jan 16, 2024
@Daveiano
Copy link
Owner

You are thinking about the temperature in the stat tile on the top, right?

243

@c0by85
Copy link
Contributor Author

c0by85 commented Jan 21, 2024

Sorry forgot to include. Yes, right there.

@Daveiano Daveiano added this to the 3.5.0 milestone Feb 10, 2024
Daveiano added a commit that referenced this issue Feb 10, 2024
@Daveiano
Copy link
Owner

Will be included in the next release! Here are some preview screenshots:

wdc-243-3
wdc-243-2
wdc-243-1

@gary-hammer
Copy link

While I like the idea of different colors for the temp, I'm not a fan of having my monochrome display have a block of changing color.

Is there a way to simply color the data, numeric temperature itself, and leave the rest of the block alone?

@Daveiano
Copy link
Owner

Understandable. I will have a talk about this with my design-colleagues ;)

Issue is reopened and re-planned for the next release.

@Daveiano Daveiano reopened this Feb 24, 2024
@Daveiano Daveiano modified the milestones: 3.5.0, 3.6.0 Feb 24, 2024
@gary-hammer
Copy link

Thank you

@Daveiano
Copy link
Owner

Daveiano commented Nov 5, 2024

@gary-hammer

my monochrome display

Wouldn't it be best to completely disable the coloured temperature if using a monochrome display? I guess if only the number is coloured, it does not add any value to the display either!?

@gary-hammer
Copy link

When I said monochrome, I mean the current look of the display.
I run on an Android tablet, it has color if course.

Perhaps just change the color of the numbers and leave the rest of the card alone

@Daveiano
Copy link
Owner

@gary-hammer

Here is an updated colored-temperatur.js file: colored-temperature.js.zip. Please feel free to copy that to your skins/weewx-wdc/dist directory.

You will also need to set this in your skin.conf:

[DisplayOptions]
    ...
    outTemp_stat_tile_color_text_only = True

And this change to skins/weewx-wdc/includes/html-head.inc 7f0b4ae#diff-dcc676d8bd36207fe0688d62d18851f93f457c5bb6530e35209128df1d8d2de1

Note: Its best to also set outTemp_stat_tile_color_transparency = 1

Please let me know if that works and looks good to you!

@gary-hammer
Copy link

I have installed the new file and made the changes indicated. Erased the output directory. Waited for a report cycle, then weectl report run to make sure all files were there and current.

So, how to get colors? My display looks the same, kinda gray. numbers.

Attaching the changes made.
wdc-color.txt

@Daveiano
Copy link
Owner

Do you have outTemp_stat_tile_color = True set in your skin.conf?

You do not need to add this at the top of the file, it should already be present in the skin.conf: https://github.com/Daveiano/weewx-wdc/blob/v3.5.1/skins/weewx-wdc/skin.conf#L152-L156

@gary-hammer
Copy link

gary-hammer commented Nov 23, 2024

Of course not .
It is default, False.
Made the change, ran the report, presto!
So, is the color temperature sensitive? Meaning blueish when < 32F red > 90F, etc.
I'm going to guess this is the color changing section:
outTemp_stat_tile_color_min = -20
outTemp_stat_tile_color_max = 40

Attached is what it looks like with the changes I've made.

Thanks!
color

@Daveiano
Copy link
Owner

Meaning blueish when < 32F red > 90F, etc. I'm going to guess this is the color changing section: outTemp_stat_tile_color_min = -20 outTemp_stat_tile_color_max = 40

Yes, exactly. You can read more about it here: https://github.com/Daveiano/weewx-wdc/wiki/Configuration

I guess the issue can be closed now?

@gary-hammer
Copy link

Yes sir, though I'm not the OP, for me it can be closed.
Thank you for the change.
I'm glad your design department agreed!

@Daveiano
Copy link
Owner

I'm glad your design department agreed!

Not completely, but sometimes a happy user is more desirable ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants