Aggregate using TimeSpan #554
Conversation
|
@heavymanto, please restore the description of this PR to include the acknowledgment section. You’ll have to check those boxes to indicate you understand what it means to contribute to an open-source project. You can get it here: .github/PULL_REQUEST_TEMPLATE.md or copy from #545 |
There was a problem hiding this comment.
A few things to fix:
- Add full unit test here:
tests/indicators/_Common/Test.QuoteHistory.cs. You only tested the external interface. - Restore the PR checklist in your description (see prior comment)
- Once you've done that, I'll add some changes to your branch to update documentation
|
@heavymanto I'd like to close and merge this PR in the next couple days, can you rebase and take a look at the issues to resolve in the comments above? |
|
Sorry for the delay. I've had a lot of work to do. I hope my changes are to your liking. |
Looks pretty good to me. I'll commit a few small items to your branch then merge it (mostly updating docs and fixing merge conflicts). |
* fix internal URLs * add redirects
* fix internal relative URL refs * use github repo variable
This Byte Order Mark Unicode character is causing problems in the IDE
* refactor: make ConvertToBasic use enum * add custom SMA/EMA that can use all OHLCV parts
* fix redirects * hardcode URLs in contributing since its a native GitHub file
+semver: minor
* refactor DPO as a sample case
* update Renko URLs * add slashes to URLs * update contributing guide * move NOTICE file * lowercase common and src folders * change header color * general doc updates
|
This Pull Request has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs. |
Description
Implements #530 to implement `PeriodSize periodsSize = MyTimeSpan.ToPeriodSize();
Checklist
Acknowledgements