Parsing optimisations #776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null types are almost certainly the least common object, so putting the check last in the list will be faster. This gave an approximate 5% performance improvement in parse_value() in tests.
This resulted in approximately 40% reduction in instructions used in parse_string() when parsing a 4MB JSON file, as measured in callgrind.
This gave an approximate 4% improvement in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run the tests through valgrind with no failures. I've also run the fuzzer for over 268435456 iterations with no problems.
On my test file, the combined effect of these commits gave a 15% performance improvement in cJSON_Parse() on my 4MB test file.