fix: some bugs in detach and replace #456
Conversation
miaoerduo
commented
Apr 3, 2020
•
miaoerduo
commented
- set list head's prev when parse_object and parse_array
- detach the first item when array size is 1
- detach the last item
- replace the first item when array size is 1
- replace the last item
miaoerduo
changed the title
| @@ -1509,6 +1509,10 @@ static cJSON_bool parse_array(cJSON * const item, parse_buffer * const input_buf | |||
| success: | |||
| input_buffer->depth--; | |||
|
|
|||
| if (head != NULL) { | |||
There was a problem hiding this comment.
@miaoerduo thanks your suggestion! but this change make the testcase fail, I have to make some changes for it.
There was a problem hiding this comment.
Maybe the 0th is unnecessary? How about the others? I have test these in my project. :P
There was a problem hiding this comment.
No, it's needed. compiling it with option cmake ENABLE_VALGRIND=On .. when make check, memory check is very important.
There was a problem hiding this comment.
Sorry, I have commited with company's email.
So I have to changed the email in commits and force pushed again.
There was a problem hiding this comment.
May my modification be merged into this project?
Is there any other thing I could do?
I haven't contributed to a project with so many stars!
There was a problem hiding this comment.
This version is released no more than 24 hours since you make this contribution, you have done a good job :), before I merge it, I need some time to make sure it won't introduce any problem.
There was a problem hiding this comment.
Wow! Thank YOU very much!
