Tightly pack the cJSON struct #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running pahole(https://linux.die.net/man/1/pahole) flags cJSON as a packable struct on x86-64. This patch moves the members of type 'int' next to each other and plugs the two 4-bytes holes. This reduces the struct size from 64-bytes to 56-bytes. see https://godbolt.org/z/gUr5ue
|
As you already mentioned, this breaks the ABI. See the issue where I'm tracking ideas of how the struct could look like in the future: #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running pahole(https://linux.die.net/man/1/pahole) flags cJSON as a
packable struct on x86-64.
This patch moves the members of type 'int' next to each other and plugs
the two 4-bytes holes. This reduces the struct size from 64-bytes to
56-bytes.
see https://godbolt.org/z/gUr5ue
I understand that this breaks the ABI. So, probably a version bump is due.