Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library_config: fix Cflags include #211

Closed
wants to merge 1 commit into from
Closed

library_config: fix Cflags include #211

wants to merge 1 commit into from

Conversation

yangfl
Copy link
Contributor

@yangfl yangfl commented Nov 4, 2017

No description provided.

@FSMaxB
Copy link
Collaborator

FSMaxB commented Nov 4, 2017

So about that: Since there is no include path added to the pkgconfig file, the canonical way to include cJSON if it wasn't copy-pasted into your source code is #include <cjson/cJSON.h>.

Adding the additional include directory would also allow #include <cJSON.h>.

I'm not very opiniated about this other than that <cjson/cJSON> still has to work, but I would like to get some feedback by other users first, maybe there are some implications that I didn't think of.

Also note that not only the pkgconfig file needs to be changed but also cJSONConfig.cmake.in.

@yangfl
Copy link
Contributor Author

yangfl commented Nov 4, 2017

OK, I've seen and I'm not against <cjson/cJSON>
But if you decide to use <cjson/cJSON>, could you mention it somewhere in the documentation?

@FSMaxB FSMaxB closed this in 3590722 Nov 4, 2017
@FSMaxB
Copy link
Collaborator

FSMaxB commented Nov 4, 2017

I added a section to the documentation.

@yangfl yangfl deleted the temp branch November 4, 2017 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants