CMakeLists.txt: swap GNUInstallDirs and project #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for wanting to improve cJSON. Can you please elaborate on what problems swapping these lines fixed? Also please split out the whitespace fix in a separate commit and remove the changes to the pkgconfig file. You can open a separate pull request for the changes to the pkgconfig files, then we can discuss it there, but please don't put multiple separate things in the same pull request. Once this is done I can merge this pull request. |
|
This would cause CMAKE_LIBRARY_ARCHITECTURE always empty, and cJSON_test always failed due to undefined symbols. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why, but this line caused thousands of problems in my host. :(