Locale independence #146
Merged
Locale independence #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This first prints the number into a temporary buffer and then copies the number to the output. A positive side effect is that cJSON no longer reserves more space for the number in the output than is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #145.
Both
parse_numberandprint_numberweren't capable of handling locales where the decimal point is not'.'.To fix this the current decimal-point is fetched via
localeconv.parse_numbernow parses the number into a buffer and replaces the'.'with the decimal-point character of the current locale.print_numberprints the number to a temporary buffer and then replaces the decimal-point with'.'when copying the number to the output. This also means that the size of the printed number is now known before space in the printbuffer is reserved, thereby loosening the space requirements forcJSON_PrintPreallocated.