Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library built via make (not cmake) lack of SONAME #252

Closed
Yanhao opened this issue Mar 29, 2018 · 7 comments
Closed

library built via make (not cmake) lack of SONAME #252

Yanhao opened this issue Mar 29, 2018 · 7 comments

Comments

@Yanhao
Copy link

Yanhao commented Mar 29, 2018

this following command show nothing while libcjson.so.1.7.5 was built via make.
readelf -d libcjson.so.1.7.5 | grep SONAME

It's google while build with cmake.

Please either fix this problem or delete Makefile only reserving CMakeLists.txt.

@FSMaxB
Copy link
Collaborator

FSMaxB commented Mar 29, 2018

I'm not sure how to set the so name when building via a makefile. Is there a compiler flag that I can set?

@FSMaxB
Copy link
Collaborator

FSMaxB commented Mar 29, 2018

(up until now I wasn't even aware of the fact that the SONAME exists in ELF files)

@Yanhao
Copy link
Author

Yanhao commented Mar 29, 2018

I'm not sure how to set the so name when building via a makefile. Is there a compiler flag that I can set?

that easy, according to this link, you could simply add soname by "gcc -Wl,-soname,libfoo.so.0"

although I think just deleting the Makefile would be a better solution.

@FSMaxB
Copy link
Collaborator

FSMaxB commented Mar 29, 2018

Great, I'll fix the Makefile in the next few days.

I won't remove it yet. That will happen with the next breaking release (2.0). But I think I will change the README that using the Makefile is not recommended.

@Tangerino
Copy link

Tangerino commented Mar 30, 2018 via email

@Yanhao
Copy link
Author

Yanhao commented Mar 30, 2018

@Tangerino Actually I am packaging this library for debian cause I believe a simple single line command "apt install libcjson-dev" is more elegant solution than copying *.c and *.h to mix them with your current sources.

@FSMaxB FSMaxB closed this as completed in ed8fefc Apr 13, 2018
@FSMaxB
Copy link
Collaborator

FSMaxB commented Apr 13, 2018

Fixed in 1.7.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants