-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macro for localeconv call. #202
Comments
Yes, please make a PR to the Also: Note that |
… the localeconv method in some SDK's. A macro named `ENABLE_LOCALES` was added and an option with the same name too in the CMakeLists.txt
Also, one question regarding the CONTRIBUTION.md: |
Yes, 4 Spaces. This is a bug. Interesting that nobody noticed this so far, including me. |
During the compilation of your library for a native application in android the following error was produced: error: undefined reference to 'localeconv'. After googling, it came up to be a common error produced by the NDKs. A solution utilizing macros was proposed to another json-related library having the same issue. I forked your project and implement the proposed solution, resulting in a successful compilation of the code.
I can make a PR but i would like to know if you prefer another name for the macro, or in general a different solution.
Current name of the macro is NO_LOCALE_SUPPORT.
The text was updated successfully, but these errors were encountered: