Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in cJSON.c cJSON_SetNumberHelper #138

Closed
mmkeeper opened this issue Mar 28, 2017 · 1 comment
Closed

Bug in cJSON.c cJSON_SetNumberHelper #138

mmkeeper opened this issue Mar 28, 2017 · 1 comment
Labels
bug

Comments

@mmkeeper
Copy link

mmkeeper commented Mar 28, 2017 •
edited
Loading

cJSON.c line 231 :
object->valueint = cJSON_Number;

may be it is type?

object->type = cJSON_Number;
object->valueint = number;
@mmkeeper mmkeeper changed the title Bub in cJSON.c cJSON_SetNumberHelper Bug in cJSON.c cJSON_SetNumberHelper Mar 28, 2017
@FSMaxB FSMaxB closed this as completed in ef34500 Mar 28, 2017
@FSMaxB FSMaxB added the bug label Mar 28, 2017
@FSMaxB
Copy link
Collaborator

FSMaxB commented Mar 28, 2017

This stuff happens with autocompletion. Really embarassing. I wonder why nobody noticed this before.

I definitely should add some tests for cJSON_SetNumberHelper.

DeguiLiu pushed a commit to DeguiLiu/cJSON that referenced this issue Jan 12, 2024
@FSMaxB
cJSON_SetNumberHelper: Fix valueint, closes DaveGamble#138
7e08573 
Thanks @mmkeeper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmkeeper @FSMaxB