Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match macosx_11_0_arm64.wheel #350

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Match macosx_11_0_arm64.wheel #350

merged 1 commit into from
Jan 28, 2022

Conversation

nasyxx
Copy link
Contributor

@nasyxx nasyxx commented Nov 8, 2021

e.g. numpy-1.21.4-cp310-cp310-macosx_11_0_arm64.whl https://pypi.org/project/numpy/#files

e.g. `numpy-1.21.4-cp310-cp310-macosx_11_0_arm64.whl`  https://pypi.org/project/numpy/#files
@DavHau
Copy link
Owner

DavHau commented Nov 9, 2021

Thanks. The problem I see with this is that it is now possible to get arm64 wheels on x86_64 and vice versa. It should probably just use the self.platform variable, like it is done for the linux wheels.
I am not sure though if self.platform yields aarch64 or arm64 in case of arm. That'd need to be checked first and potentially mapped correctly

@nasyxx
Copy link
Contributor Author

nasyxx commented Nov 9, 2021

Thanks. The problem I see with this is that it is now possible to get arm64 wheels on x86_64 and vice versa.

Sounds bad.

I am not sure though if self.platform yields aarch64 or arm64 in case of arm. That'd need to be checked first and potentially mapped correctly

If you need to test on an arm mac machine, just let me know.

@NikolayTach
Copy link

NikolayTach commented Dec 4, 2021

#985997686

@hazelweakly
Copy link
Contributor

@DavHau , it's arm64 according to: google/or-tools#2332 (comment)

So it should be able to naively be mapped, same as the linux ones currently are.

@didierck
Copy link

Hello,
For those interested, I have managed to compile or tools python 9.2.9972 on my M1 without SCIP
ortools-9.2.9972-cp39-cp39-macosx_11_0_arm64.whl.zip.
Let me know if you need more information.

DavHau added a commit that referenced this pull request Jan 28, 2022
@DavHau DavHau closed this in 2e63cb5 Jan 28, 2022
@DavHau DavHau merged commit 7c05e2b into DavHau:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants