Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canon next 0.1.5 #1379

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Canon next 0.1.5 #1379

merged 7 commits into from
Mar 29, 2023

Conversation

scespinoza
Copy link
Contributor

@scespinoza scespinoza commented Mar 2, 2023

  • Adds custom sections support.
  • Improves ProfileSearch component

Update: 0.1.6 pushes back on custom sections. Working on the monorepo, but not on the monshaat project, its a breaking change so I had to roll back.

@scespinoza scespinoza requested a review from davelandry March 2, 2023 19:45
Copy link
Member

@davelandry davelandry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scespinoza this is looking great, and it makes sense to me. I see what you mean about commenting out the customSections for now. Are you intending for me to merge/release this so we can get the ProfileSearch improvements, or do you want to keep working in here until you get CustomSections working? (if so, I'd also like you to add something to the README describing the folder/config settings needed!)

example-next/pages/profile/[...members].js Show resolved Hide resolved
@scespinoza
Copy link
Contributor Author

scespinoza commented Mar 3, 2023

@davelandry do not merge yet!! I want to get CustomSections working, and yes, the Readme.md update is on my mind, but as I haven't been able to figure out the correct setup, I haven't included it yet I hope to get it working early next week. And btw, this is already released as I needed it on monshaat 😅 I just wanted to get your comments on the CustomSections implementation

@bidwolf
Copy link

bidwolf commented Mar 26, 2023

Hey guys, Good morning!
I'm working to update a new version of a Brazilian website: codelife.com that depends on canon's old versions to work.
I would like to maintain this partnership, I would love it if it were possible to integrate this framework with next-js and the new versions of react, so if I can help in any way I'm open to that.

@davelandry
Copy link
Member

hi @bidwolf! I just published a version of an internal guide we wrote to start migrating projects to Nextjs (and completely abandoning canon-core). Check it out, and if you have any questions please make a new Github issue in this repository and we can discuss/help!

https://github.com/Datawheel/canon/wiki/Migrating-from-canon-to-Next.js

@davelandry davelandry merged commit cc73e7e into master Mar 29, 2023
@davelandry davelandry deleted the canon-next-0.1.5 branch March 29, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants