Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize support, again #1347

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Optimize support, again #1347

merged 4 commits into from
Feb 4, 2022

Conversation

palamago
Copy link
Member

@palamago palamago commented Feb 4, 2022

  • Rolled back to load the script at the very beginning of <head>.
  • We found an "infinite loop" issue implementing the redirect test strategy into oec, so we moved to a "custom event" launch strategy to give us more control and a better performance.
    See more under "Option 2..." title here: https://support.google.com/optimize/answer/7008840?hl=en

@palamago palamago requested a review from davelandry February 4, 2022 12:20
@jhmullen jhmullen merged commit 11e49df into master Feb 4, 2022
@jhmullen jhmullen deleted the optimize-support branch February 4, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelandry davelandry Awaiting requested review from davelandry

Assignees

@jhmullen jhmullen

Labels
effort: 4 - easy package: core priority: 2 - high type: enhancement Small, low-risk improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palamago @jhmullen