Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] removes full node_modules transpiling #1264

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Conversation

davelandry
Copy link
Member

This PR changes the default transpiling of all node_modules dependencies to just transpiling node_modules/@datawheel dependencies. This has the side-effect of dropping IE11 support, as most common day packages now publish code with ES6 features like const and =>, which are only supported in modern browsers.

@jhmullen I'm not sure if this should be v0.24.2, or a full v0.25.0. I leave that decision up to you. 🙏🏻

As a positive side-effect, using oec-site for testing, this change reduced the production build time from ~3.5 minutes down to ~2.5 minutes, and changed the build size from 4.11mb down to 4.02mb.

Before

before

After

after

Sidenote: anytime I do stuff locally in this repo, it marks canon-cms-ingest.js as modified but I'm unable to see any changed either in VSCode or using git diff. I committed here as more of a future self-sanity thing, assuming that maybe my stricter linter caught some invisible encoding issue or something.

@davelandry davelandry requested a review from jhmullen October 5, 2021 17:29
@davelandry davelandry self-assigned this Oct 5, 2021
@jhmullen jhmullen merged commit 115e56c into master Oct 6, 2021
@jhmullen jhmullen deleted the core-loaders-fix branch October 6, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants