[core] removes full node_modules transpiling #1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default transpiling of all
node_modules
dependencies to just transpilingnode_modules/@datawheel
dependencies. This has the side-effect of dropping IE11 support, as most common day packages now publish code with ES6 features likeconst
and=>
, which are only supported in modern browsers.@jhmullen I'm not sure if this should be v0.24.2, or a full v0.25.0. I leave that decision up to you. 🙏🏻
As a positive side-effect, using oec-site for testing, this change reduced the production build time from ~3.5 minutes down to ~2.5 minutes, and changed the build size from 4.11mb down to 4.02mb.
Before
After