Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vizbuilder] filter values should respect format multipliers #325

Closed
davelandry opened this issue Nov 30, 2018 · 0 comments · Fixed by #329
Closed

[vizbuilder] filter values should respect format multipliers #325

davelandry opened this issue Nov 30, 2018 · 0 comments · Fixed by #329
Assignees
@frabarz
Labels
type: bug

Comments

@davelandry
Copy link
Member

For example, if I'd like to filter by a rate by values greater than 5%, I would expect to type this:

screen shot 2018-11-30 at 3 29 56 pm

But that's really 500%:

screen shot 2018-11-30 at 3 29 47 pm

The best way to go about this may be to have formatters separate from something called multipliers, and each formatter would reference the multiplier if it exists.
@davelandry davelandry mentioned this issue Nov 30, 2018
Closed
frabarz added a commit that referenced this issue Dec 4, 2018
@frabarz
implements measure value multipliers and fix for filters
6a76859 
extracts initialization in Vizbuilder constructor to own function
removes unused variables
closes #325
@frabarz frabarz mentioned this issue Dec 4, 2018
Merged
davelandry pushed a commit that referenced this issue Dec 5, 2018
@frabarz @davelandry
implements measure value multipliers and fix for filters
1bdb486 
extracts initialization in Vizbuilder constructor to own function
removes unused variables
closes #325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frabarz frabarz

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vizbuilder] chart calculation refactor and feedback issues Datawheel/canon
2 participants
@davelandry @frabarz