Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vizbuilder] unable to define a custom fitFilter #309

Closed
davelandry opened this issue Nov 28, 2018 · 3 comments · Fixed by #329
Closed

[vizbuilder] unable to define a custom fitFilter #309

davelandry opened this issue Nov 28, 2018 · 3 comments · Fixed by #329
Assignees

Comments

@davelandry
Copy link
Member

davelandry commented Nov 28, 2018

Trying to do this:

<Vizbuilder config={{fitFilter: myFunction}} />

Probably related to this line:

config.fitFilter = d => levelCutMembers.indexOf(d.id) > -1;

This shouldn't get set if the user has defined one.

@davelandry
Copy link
Member Author

@frabarz I'm still having trouble setting this. Here's a live example (in d3plus) of the behavior I'm trying to achieve: http://jsfiddle.net/dr8ycq4b/

@frabarz
Copy link
Collaborator

frabarz commented Dec 23, 2018

Are you sure? I tried in my local and can't replicate:

image

image

@davelandry
Copy link
Member Author

@frabarz hmm, ok I'll dig deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants