Support multi architecture building #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roehrich-hpe
requested review from
nathandotleeathpe and
roehrich-hpe
and removed request for
nathandotleeathpe
|
roehrich-hpe
approved these changes
Mar 19, 2024
Signed-off-by: Dean Roehrich <[email protected]>
roehrich-hpe
force-pushed
the
multi-arch
branch
from
dfaeeb7 to
c66ac17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running through the example at https://github.com/DataWorkflowServices/dws-slurm-bb-plugin?tab=readme-ov-file#the-integration-test-environment-as-a-playground with the latest versions of everything and am making PRs based on changes I found I need for proper building on arm.
Using TARGETARCH in the dockerfile should retain functionality for amd64 and allow for building on other archs. It also opens up the possibility for multi arch images.