Teardown fix #47
Merged
Teardown fix #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dean Roehrich <[email protected]>
roehrich-hpe
requested review from
ajfloeder,
matthew-richerson,
bdevcich and
kpelzel
matthew-richerson
approved these changes
Sep 28, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While teardown technically still works, I get an error in the slurm log when returning nil as the second return value in the teardown script. This PR returns an empty string instead.
[2023-09-26T19:11:37.457] slurmscriptd: error: _handle_lua_return: Cannot handle non-string as second return value for lua function slurm_bb_job_teardown.