Update tests to support fatal errors #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DWS v0.0.11 has the concept of fatal errors. This updates the tests to use fatal errors, and to show how drivers should handle them. Signed-off-by: Dean Roehrich <[email protected]>
roehrich-hpe
requested review from
inf0rmatiker,
ajfloeder,
matthew-richerson and
bdevcich
|
bdevcich
reviewed
Aug 29, 2023
| @@ -35,8 +36,8 @@ Feature: Data Workflow Services State Progression | |||
| /bin/hostname | |||
|
|
|||
| When the job is run | |||
| And a Workflow is created for the job | |||
| Then the Workflow and job progress to the Proposal state | |||
| Then a Workflow has been created for the job | |||
There was a problem hiding this comment.
What's the difference between Then/And in this case?
There was a problem hiding this comment.
As I was reading the list of statements, I thought it felt like an arbitrary thing, as far as when to switch from the "When" list to the "Then" list. And so I pulled "Then" up a little higher in the list because that's how I felt that day.
bdevcich
reviewed
Aug 29, 2023
| # wait=wait_fixed(2), | ||
| # stop=stop_after_attempt(30), | ||
| # reraise=True | ||
| #) |
bdevcich
approved these changes
Aug 29, 2023
matthew-richerson
approved these changes
Aug 29, 2023
Signed-off-by: Dean Roehrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DWS v0.0.11 has the concept of fatal errors. This updates the tests to use fatal errors, and to show how drivers should handle them.
This also addresses a number of lint errors, but does not attempt to remove all of them.