Added integration tests for error scenarios and added error observability to plugin #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
…taWorkflowServices#28) * Using dws-test-driver for DWS state progression integration tests Signed-off-by: Nathan Lee <[email protected]> * Fixed integration test errors Signed-off-by: Nathan Lee <[email protected]> * code review changes Signed-off-by: Nathan Lee <[email protected]> * Updated dws-test-driver to main branch HEAD Signed-off-by: Nathan Lee <[email protected]> * Code review Signed-off-by: Nathan Lee <[email protected]> --------- Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
|
roehrich-hpe
reviewed
Feb 6, 2023
Signed-off-by: Nathan Lee <[email protected]>
|
Would you please update the dws-test-driver and slurm-docker-cluster submodules with this PR? When they're not pointing into 'main' then the github cli tool has trouble checking out this PR: Maybe that's a commit in one of your personal forks? |
Signed-off-by: Nathan Lee <[email protected]>
|
When you update the submodules, you should leave 'dws' at v0.0.6, until we snap another release of it. |
roehrich-hpe
reviewed
Feb 6, 2023
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
roehrich-hpe
reviewed
Feb 9, 2023
Signed-off-by: Nathan Lee <[email protected]>
Signed-off-by: Nathan Lee <[email protected]>
roehrich-hpe
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added integration tests simulating driver errors at each DWS stage. The feature file contains a comment detailing how the tests need to change if
Flags=TeardownFailureis configured.Driver errors are now returned to Slurm, allowing the errors to show up in the
SystemCommentfield inscontroloutput. This was written using a json path to return all DriverStatus entries for the current watch state and then filtering through those entries to find Errors. The json path was designed to handle multiline driver errors. Also note that lua iterators will return "nil" if you have reached the end of their queue.The unit tests were updated to cover the driver error handling. Previously, the unit tests were written to also run against a live k8s and slurm environment. The integration tests remove the need for this feature, so I removed it. I also removed the old CRD validator tool for the same reason.