Correctly handle compressing empty slice #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoiron
approved these changes
Oct 1, 2018
bobrik
added a commit
to bobrik/sarama
that referenced
this pull request
Oct 1, 2018
This reverts commit 0f30d97. The issue was fixed in DataDog/zstd#42
bobrik
added a commit
to bobrik/sarama
that referenced
this pull request
Oct 1, 2018
This reverts commit 0f30d97. The issue was fixed in DataDog/zstd#42
bobrik
added a commit
to bobrik/sarama
that referenced
this pull request
Oct 2, 2018
This reverts commit 0f30d97. The issue was fixed in DataDog/zstd#42
elijahandrews
added a commit
that referenced
this pull request
Jan 10, 2019
elijahandrews
added a commit
that referenced
this pull request
Jan 16, 2019
backport #42 to 0.5.x (Correctly handle compressing empty slice), handle decompressing empty byte slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
The current behavior is on the
Compress/Decompress, when we give an empty slice for compression, the library return anEmptySliceerror. This makes sense forDecompress(since it's not a correct zstd message) but not forCompress.Also this has a different behavior than the streaming version as those works correctly with empty slices
As #41 points out, the
zstdcli correctly returns a slice for empty slice, we should do the same