Allow retry logic in synthetics tests

[s33dunda]

This is a bit of a dupe of https://github.com/terraform-providers/terraform-provider-datadog/pull/425.
Allows for retry logic in synthetics checks.

However, this uses the terraform migration pattern as suggested here https://www.terraform.io/docs/extend/resources/state-migration.html

This way we can keep options without deprecating and/or breaking those upgrading.

[bendrucker]

Also opened (and just closed) #426. This is great, first time seeing a state migrator in action!

[s33dunda]

@gzussa @jirikuncar I can't seem to get the tests to pass. However, if I use my personal api keys it passes:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDatadogSynthetics* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-datadog	[no test files]
=== RUN   TestAccDatadogSyntheticsAPITest_importBasic
=== PAUSE TestAccDatadogSyntheticsAPITest_importBasic
=== RUN   TestAccDatadogSyntheticsSSLTest_importBasic
=== PAUSE TestAccDatadogSyntheticsSSLTest_importBasic
=== RUN   TestAccDatadogSyntheticsBrowserTest_importBasic
=== PAUSE TestAccDatadogSyntheticsBrowserTest_importBasic
=== RUN   TestAccDatadogSyntheticsAPITest_Basic
--- PASS: TestAccDatadogSyntheticsAPITest_Basic (1.25s)
=== RUN   TestAccDatadogSyntheticsAPITest_Updated
--- PASS: TestAccDatadogSyntheticsAPITest_Updated (1.62s)
=== RUN   TestAccDatadogSyntheticsSSLTest_Basic
--- PASS: TestAccDatadogSyntheticsSSLTest_Basic (1.02s)
=== RUN   TestAccDatadogSyntheticsSSLTest_Updated
--- PASS: TestAccDatadogSyntheticsSSLTest_Updated (1.67s)
=== RUN   TestAccDatadogSyntheticsBrowserTest_Basic
--- PASS: TestAccDatadogSyntheticsBrowserTest_Basic (1.14s)
=== RUN   TestAccDatadogSyntheticsBrowserTest_Updated
--- PASS: TestAccDatadogSyntheticsBrowserTest_Updated (1.78s)
=== CONT  TestAccDatadogSyntheticsAPITest_importBasic
=== CONT  TestAccDatadogSyntheticsBrowserTest_importBasic
=== CONT  TestAccDatadogSyntheticsSSLTest_importBasic
--- PASS: TestAccDatadogSyntheticsAPITest_importBasic (1.08s)
--- PASS: TestAccDatadogSyntheticsSSLTest_importBasic (1.15s)
--- PASS: TestAccDatadogSyntheticsBrowserTest_importBasic (6.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-datadog/datadog	16.368s
?   	github.com/terraform-providers/terraform-provider-datadog/version	[no test files]

not really sure what the deal is here. :(

Any ideas?

[bendrucker]

This is because there are recorded API requests/responses in cassettes/. Not sure what the plan is for updating those.

[lem2clide]

This is a bit of a dupe of #425.
Allows for retry logic in synthetics checks.

However, this uses the terraform migration pattern as suggested here https://www.terraform.io/docs/extend/resources/state-migration.html

This way we can keep options without deprecating and/or breaking those upgrading.

I was not aware of the state-migration feature, I've updated the PR https://github.com/terraform-providers/terraform-provider-datadog/pull/425 to add StateUpgrader and an upgrade test, thanks for that great suggestion @s33dunda !

[bkabrda]

Hey @s33dunda, would you be ok with closing this PR and consolidating the effort in #425?

[s33dunda]

@bkabrda whatever it takes to get have this available for all of us. Was there anything particular to keep from each PR?

[therve]

We added retry support in #619, let us know if it works for you.