Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboards] Safely type assert optional fields from log and apm query #283

Merged
merged 2 commits into from
Aug 13, 2019
Merged

[dashboards] Safely type assert optional fields from log and apm query #283

merged 2 commits into from
Aug 13, 2019
+7 −5

Conversation

jbenais
Copy link
Contributor

@jbenais jbenais commented Aug 9, 2019 •
edited
Loading

  • Add a safe type assert for all optional fields in the dashboard resource (includes sort->facet and compute->interval).
  • Update documentation

@ghost ghost added the size/XS label Aug 9, 2019
@jbenais jbenais changed the title [dashboardsSafely type assert optional fields from log and apm query [dashboards] Safely type assert optional fields from log and apm query Aug 9, 2019
enbashi
enbashi approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@enbashi enbashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jbenais jbenais force-pushed the julia/type-assert-optonal-fields branch from db5e9b8 to 870c99b Compare August 9, 2019 15:28
@ghost ghost added the documentation label Aug 9, 2019
gzussa
gzussa approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

nmuesch
nmuesch approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the fix!

@nmuesch nmuesch merged commit 6296b6d into DataDog:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmuesch nmuesch nmuesch approved these changes

@enbashi enbashi enbashi approved these changes

@gzussa gzussa gzussa approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbenais @gzussa @enbashi @nmuesch