Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable test now that change is merged on dotnet side #2984

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

vandonr
Copy link
Contributor

@vandonr vandonr commented Sep 5, 2024

test was marked disabled in #2903
to make way for DataDog/dd-trace-dotnet#5859

@vandonr vandonr marked this pull request as ready for review September 25, 2024 13:31
@vandonr vandonr requested a review from a team as a code owner September 25, 2024 13:31
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is your fix has been released ? I'm surprised to see that the test passes on your released lib? 🤔

@cbeauchesne
Copy link
Collaborator

Is your fix has been released ? I'm surprised to see that the test passes on your released lib? 🤔

DataDog/dd-trace-dotnet#5859 has been merged 3 weeks ago, the last dd-trace-dotnet release was one week ago -> this Pr is shipped inside the last release, so it's normal to have prod green.

@vandonr vandonr merged commit d6404d5 into main Sep 26, 2024
274 checks passed
@vandonr vandonr deleted the vandonr/sys branch September 26, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants