Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] special case to avoid false positive easy win #2401

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Apr 26, 2024

Motivation

The test is a false positive easy-win that we can't figure out how to fix.

Changes

When the DD_API_SECURITY_PARSE_RESPONSE_BODY env var is used, the test will fail on purpose with "not implemented".

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@simon-id simon-id self-assigned this Apr 26, 2024
@simon-id simon-id marked this pull request as ready for review April 26, 2024 14:56
@simon-id simon-id requested review from a team as code owners April 26, 2024 14:56
@simon-id simon-id merged commit 952bc46 into main Apr 26, 2024
29 of 36 checks passed
@simon-id simon-id deleted the simon-id-patch-1 branch April 26, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants