-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable OpenTelemetry tests for Ruby #1456
Conversation
Co-authored-by: Charles de Beauchesne <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruby fails in CI/parametric, is it related ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @marcotc , it's still failing on activated test, or did I missed something ?
Fixed the issues pointed out, thank you!
Description
This PR implements the parametric system-tests gRPC server to back the Ruby Tracer OpenTelmetry integration.
All tests are passing for Ruby after this PR merges.
Depends on DataDog/dd-trace-rb#3026 to be released for tests to go green.
Motivation
Workflow
Once your PR is reviewed, you can merge it! ❤️
Reviewer checklist
run-parametric-scenario
,run-profiling-scenario
...). If this PR modifies any system-tests internal, then add therun-all-scenarios
label (more info).build-some-image
label is presentWhen we hit the rate limit (HTTP 429), retry after the time specified in
the response. This does not count toward the number of retries based on
other criteria.