Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OpenTelemetry tests for Ruby #1456

Merged
merged 21 commits into from
Nov 22, 2023
Merged

Enable OpenTelemetry tests for Ruby #1456

merged 21 commits into from
Nov 22, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Aug 4, 2023

Description

This PR implements the parametric system-tests gRPC server to back the Ruby Tracer OpenTelmetry integration.

All tests are passing for Ruby after this PR merges.

Depends on DataDog/dd-trace-rb#3026 to be released for tests to go green.

Motivation

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
      When we hit the rate limit (HTTP 429), retry after the time specified in
      the response. This does not count toward the number of retries based on
      other criteria.

@marcotc marcotc marked this pull request as ready for review August 11, 2023 22:59
@marcotc marcotc requested a review from a team August 11, 2023 22:59
@marcotc marcotc requested review from a team as code owners August 11, 2023 22:59
@marcotc marcotc requested review from a team and removed request for a team August 11, 2023 22:59
tests/parametric/test_otel_span_methods.py Outdated Show resolved Hide resolved
tests/parametric/test_otel_span_methods.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruby fails in CI/parametric, is it related ?

Base automatically changed from kylev/dc to main August 29, 2023 18:11
@marcotc marcotc changed the base branch from main to fix-typo-otel November 17, 2023 21:47
@marcotc marcotc marked this pull request as draft November 17, 2023 23:46
Base automatically changed from fix-typo-otel to main November 20, 2023 20:36
@marcotc marcotc marked this pull request as ready for review November 21, 2023 00:31
@marcotc marcotc requested a review from cbeauchesne November 21, 2023 00:32
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcotc marcotc dismissed cbeauchesne’s stale review November 21, 2023 20:49

Fixed the issues pointed out, thank you!

@marcotc marcotc merged commit acbc0d0 into main Nov 22, 2023
165 checks passed
@marcotc marcotc deleted the ruby-otel branch November 22, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants