-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix message when sfn->Lambda context injection is already set … #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
🚨 MergeQueue: This merge request is in error mergequeue build completed successfully, but the github api returned an error while merging the pr.
DetailsError: PUT https://api.github.com/repos/DataDog/serverless-plugin-datadog/pulls/536/merge: 405 4 of 4 required status checks are expected. [] FullStacktrace: If you need support, contact us on Slack #devflow with those details! |
…up using Payload.$
ba3c33d
to
e238a53
Compare
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
…up using Payload.$
Motivation
If
serverless.yml
is already setting up sfn->Lambda context injection using thePayload.$
field:right now our plugin will print a message:
This shouldn't be a
[Warn]
. We usually only add[Warn]
when context injection is not set up yet and skipped for some reason.What does this PR do?
Remove the
[Warn]
Testing Guidelines
Additional Notes
Types of changes
Check all that apply