Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix message when sfn->Lambda context injection is already set … #536

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Sep 27, 2024

…up using Payload.$

Motivation

If serverless.yml is already setting up sfn->Lambda context injection using the Payload.$ field:

Payload.$: "States.JsonMerge($$, $, false)"

right now our plugin will print a message:
image

This shouldn't be a [Warn]. We usually only add [Warn] when context injection is not set up yet and skipped for some reason.

What does this PR do?

Remove the [Warn]

Testing Guidelines

image

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner September 27, 2024 20:41
Copy link

@avedmala avedmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lym953
Copy link
Contributor Author

lym953 commented Sep 30, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 30, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 2m.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 30, 2024

🚨 MergeQueue: This merge request is in error

mergequeue build completed successfully, but the github api returned an error while merging the pr.
It's probably because:

  • repository configuration requires approval by code owners, but no code owner approved this PR
  • target branch of PR is restricted to only allow up-to-date branches, but the pr is now outdated
Details

Error: PUT https://api.github.com/repos/DataDog/serverless-plugin-datadog/pulls/536/merge: 405 4 of 4 required status checks are expected. []

FullStacktrace:
activity error (type: github.GithubService_MergePullRequest, scheduledEventID: 41, startedEventID: 42, identity: 1@github-worker-5f86d7f7c8-jlx2t@): PUT https://api.github.com/repos/DataDog/serverless-plugin-datadog/pulls/536/merge: 405 4 of 4 required status checks are expected. [] (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@lym953 lym953 force-pushed the yiming.luo/fix-sfn-context-injection-14 branch from ba3c33d to e238a53 Compare September 30, 2024 15:21
@lym953
Copy link
Contributor Author

lym953 commented Sep 30, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 30, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Sep 30, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 2m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 36201b5 into main Sep 30, 2024
10 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yiming.luo/fix-sfn-context-injection-14 branch September 30, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants