feat: Support sfn->Lambda context injection when Payload.$ exists (case 4) #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
commented
Sep 26, 2024
| ); | ||
| return; | ||
| } | ||
|
|
||
| serverless.cli.log( |
There was a problem hiding this comment.
Deleting this code because it's unreachable.
BTW I will refactor this function to make it hopefully more clear.
lym953
force-pushed
the
yiming.luo/fix-sfn-context-injection-9
branch
from
d6e5f3f
to
95a8379
Compare
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
yiming.luo/fix-sfn-context-injection-9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handles context injection from Step Function to Lambda Invoke step when
Payload.$is set."Payload.$": "$": change to"Payload.$": "States.JsonMerge($$, $, false)""Payload.$": "States.JsonMerge($$, $, false)"or"$$['Execution', 'State', 'StateMachine']": do nothingPayload.$has other values: print a warning and skip context injectionThis corresponds to Case 4 in the design doc Fixing Step Function Instrumentation
Motivation
Testing Guidelines
Passed the existing and added tests
Additional Notes
Types of changes
Check all that apply