Support ARM layers #184
Merged
Support ARM layers #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 75.45% 76.08% +0.62%
==========================================
Files 10 10
Lines 603 623 +20
Branches 159 164 +5
==========================================
+ Hits 455 474 +19
Misses 91 91
- Partials 57 58 +1
Continue to review full report at Codecov.
|
maxday
reviewed
Oct 22, 2021
maxday
reviewed
Oct 22, 2021
etaoins
added a commit
to seek-oss/skuba
that referenced
this pull request
Nov 3, 2021
These are a bit cheaper and a bit faster than the x86 Lambdas: <https://aws.amazon.com/blogs/aws/aws-lambda-functions-powered-by-aws-graviton2-processor-run-your-functions-on-arm-and-get-up-to-34-better-price-performance/> The underlying Lambda architecture should be invisible to typical TypeScript Lambdas. Indirect Apply has switched over all of their Lambdas, only encountering difficulty with DataDog/serverless-plugin-datadog#184
etaoins
added a commit
to seek-oss/skuba
that referenced
this pull request
Nov 3, 2021
* Switch `lambda-sqs-worker` template to ARM64 These are a bit cheaper and a bit faster than the x86 Lambdas: <https://aws.amazon.com/blogs/aws/aws-lambda-functions-powered-by-aws-graviton2-processor-run-your-functions-on-arm-and-get-up-to-34-better-price-performance/> The underlying Lambda architecture should be invisible to typical TypeScript Lambdas. Indirect Apply has switched over all of their Lambdas, only encountering difficulty with DataDog/serverless-plugin-datadog#184 * Reword title * Format for prettier * Downgrade to patch Co-authored-by: Ryan Ling <[email protected]> * Less bogus words Co-authored-by: Ryan Ling <[email protected]> Co-authored-by: Ryan Ling <[email protected]>
jcstorms1
reviewed
Nov 12, 2021
There was a problem hiding this comment.
Hey @duncanista this looks good to me but I'd get a second pair of eyes on it if that's OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for ARM layers. Check SLS-1387.
Swap previous layer if lambda layers already contain a previous version.
Motivation
Follow up with
Testing Guidelines
Additional Notes
Upgraded SLS Framework to latest version.
Types of changes
Check all that apply