Allow multiple instances in mysql #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IanCrouch thanks a lot for this PR, indeed mysql should be a multi-instance manifest/config, so this is great. Unfortunately, this has broken the spec tests.... Could you please take a look and see what needs fixing? Thanks! |
|
@IanCrouch Any way you could fix the merge conflict and the spec tests? This would help us a lot so that we don't have to modify the forge module locally every time we upgrade. Cheers! |
|
@rabidscorpio I'll look into it. Sorry work took me away for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea for this is along the lines of #155. I needed to be able to check multiple MySQL instances on the same host so I modified the integration a bit to support this.
I saw #147 has been under discussion for a while and needed something quick. This should have backward comparability as I've tested it in our environment. Would like some additional feedback on how this works for others.