Add mesos_role parameter #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This influences the yaml file that puppet creates, so that the datadog agent can correctly differentiate between mesos worker and master nodes.
|
@jangie thanks a lot for your contribution, we'll check this out and hopefully merge soon. |
|
Conflicts a little bit with #174 which introduces manifests for both slave and master roles. I liked this approach, but there could be greater divergence between the two config files in the future, so I'll probably merge in what was described in the other PR. I'll keep you posted. |
|
By all means, if #174 does the differentiation between the two roles more to your liking, please do feel free to close this. I'm just wanting to ensure that there is some differentiation, so any work towards that in the official repo is good by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This influences the yaml file that puppet creates, so that the datadog
agent can correctly differentiate between mesos worker and master nodes.
This is to resolve #163 .