Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch logging framework to zerolog #478

Merged
merged 8 commits into from
Jan 6, 2025

Fix race condition in goflags

eb86f33
Select commit
Loading
Failed to load commit list.
Merged

chore: switch logging framework to zerolog #478

Fix race condition in goflags
eb86f33
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2025 in 1s

65.13% (+0.65%) compared to c0544c7

View this Pull Request on Codecov

65.13% (+0.65%) compared to c0544c7

Details

Codecov Report

Attention: Patch coverage is 72.27139% with 94 lines in your changes missing coverage. Please review.

Project coverage is 65.13%. Comparing base (c0544c7) to head (eb86f33).

Files with missing lines Patch % Lines
main.go 40.47% 24 Missing and 1 partial ⚠️
internal/jobserver/buildid/version.go 68.42% 8 Missing and 4 partials ⚠️
internal/cmd/server.go 61.53% 10 Missing ⚠️
internal/jobserver/common/handler.go 40.00% 9 Missing ⚠️
internal/jobserver/server.go 72.00% 4 Missing and 3 partials ⚠️
internal/cmd/toolexec.go 69.23% 1 Missing and 3 partials ⚠️
internal/goflags/flags.go 89.74% 3 Missing and 1 partial ⚠️
internal/goproxy/dashc.go 40.00% 3 Missing ⚠️
internal/jobserver/client/env.go 75.00% 3 Missing ⚠️
internal/toolexec/aspect/linkdeps/linkdeps.go 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   64.47%   65.13%   +0.65%     
==========================================
  Files         190      186       -4     
  Lines       11364    11341      -23     
==========================================
+ Hits         7327     7387      +60     
+ Misses       3493     3391     -102     
- Partials      544      563      +19
Components Coverage Δ
Generators 76.15% <ø> (ø)
Instruments 73.41% <ø> (ø)
Go Driver 77.20% <86.53%> (+1.33%) ⬆️
Toolexec Driver 73.97% <90.19%> (-0.22%) ⬇️
Aspects 80.10% <ø> (ø)
Injector 78.03% <81.81%> (-0.01%) ⬇️
Job Server 73.08% <69.44%> (+5.33%) ⬆️
Integration Test Suite 57.61% <ø> (ø)
Other 65.13% <72.27%> (+0.65%) ⬆️
Files with missing lines Coverage Δ
internal/ensure/requiredversion.go 88.40% <100.00%> (+0.34%) ⬆️
internal/goproxy/proxy.go 77.41% <100.00%> (+0.37%) ⬆️
internal/injector/write.go 54.54% <100.00%> (+2.16%) ⬆️
internal/jobserver/buildid/buildid.go 100.00% <100.00%> (ø)
internal/jobserver/pkgs/pkgs.go 100.00% <100.00%> (ø)
internal/toolexec/aspect/oncompile-main.go 65.38% <100.00%> (ø)
internal/toolexec/aspect/onlink.go 64.70% <100.00%> (ø)
internal/toolexec/aspect/resolve.go 61.53% <100.00%> (ø)
internal/toolexec/version.go 52.38% <100.00%> (+2.38%) ⬆️
internal/cmd/go.go 37.50% <66.66%> (ø)
... and 20 more
View more details on Codecov