-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new test-main
join point
#394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test-main` join point allows to only/never inject into nodes contained in the `main` package generated by `go test`. This is useful to avoid starting the tracer & profiler during tests, which simplifies the CI visibility aspects a little bit.
tonyredondo
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏻 Thanks!
rarguelloF
reviewed
Nov 15, 2024
Co-authored-by: Rodrigo Argüello <[email protected]>
eliottness
approved these changes
Nov 29, 2024
…-main # Conflicts: # internal/injector/builtin/generated.go
RomainMuller
force-pushed
the
romain.marcadier/test-main
branch
from
November 29, 2024 13:10
5162ae3
to
2e38007
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 63.96% 64.03% +0.07%
==========================================
Files 181 182 +1
Lines 10989 11017 +28
==========================================
+ Hits 7029 7055 +26
Misses 3433 3433
- Partials 527 529 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test-main
join point allows to only/never inject into nodescontained in the
main
package generated bygo test
. This is usefulto avoid starting the tracer & profiler during tests, which simplifies
the CI visibility aspects a little bit.