Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new test-main join point #394

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Conversation

RomainMuller
Copy link
Contributor

The test-main join point allows to only/never inject into nodes
contained in the main package generated by go test. This is useful
to avoid starting the tracer & profiler during tests, which simplifies
the CI visibility aspects a little bit.

The `test-main` join point allows to only/never inject into nodes
contained in the `main` package generated by `go test`. This is useful
to avoid starting the tracer & profiler during tests, which simplifies
the CI visibility aspects a little bit.
@RomainMuller RomainMuller requested a review from a team as a code owner November 14, 2024 14:19
@RomainMuller RomainMuller self-assigned this Nov 14, 2024
Copy link
Member

@tonyredondo tonyredondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 Thanks!

…-main

# Conflicts:
#	internal/injector/builtin/generated.go
@eliottness eliottness disabled auto-merge November 29, 2024 11:08
@RomainMuller RomainMuller force-pushed the romain.marcadier/test-main branch from 5162ae3 to 2e38007 Compare November 29, 2024 13:10
@RomainMuller RomainMuller added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 9819ebb Dec 5, 2024
36 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/test-main branch December 5, 2024 11:11
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (a7f00ee) to head (e035f74).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/injector/aspect/join/testmain.go 85.71% 1 Missing and 1 partial ⚠️
internal/toolexec/proxy/compile.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   63.96%   64.03%   +0.07%     
==========================================
  Files         181      182       +1     
  Lines       10989    11017      +28     
==========================================
+ Hits         7029     7055      +26     
  Misses       3433     3433              
- Partials      527      529       +2     
Components Coverage Δ
Generators 76.69% <ø> (ø)
Instruments 73.41% <ø> (ø)
Go Driver 78.62% <ø> (ø)
Toolexec Driver 74.07% <77.77%> (+0.25%) ⬆️
Aspects 78.70% <88.88%> (+0.13%) ⬆️
Injector 77.22% <89.47%> (+0.09%) ⬆️
Job Server 67.07% <ø> (ø)
Integration Test Suite 57.58% <ø> (ø)
Other 64.03% <86.20%> (+0.07%) ⬆️
Files with missing lines Coverage Δ
internal/cmd/toolexec.go 55.17% <100.00%> (ø)
internal/injector/aspect/context/context.go 97.01% <100.00%> (+0.18%) ⬆️
internal/injector/aspect/join/join.go 86.27% <ø> (ø)
internal/injector/injector.go 77.19% <100.00%> (+0.20%) ⬆️
internal/toolexec/aspect/oncompile.go 72.41% <100.00%> (+0.23%) ⬆️
internal/injector/aspect/join/testmain.go 85.71% <85.71%> (ø)
internal/toolexec/proxy/compile.go 78.26% <75.00%> (-0.69%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants