Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mechanism to fingerprint arbitrary data #392

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Nov 13, 2024

Provides a facility to efficiently fingerprint the injector
configuration.

@RomainMuller RomainMuller requested a review from a team as a code owner November 13, 2024 15:25
@RomainMuller RomainMuller self-assigned this Nov 13, 2024
@RomainMuller RomainMuller force-pushed the romain.marcadier/APPSEC-55160/fingerprinter branch from 093178e to 3f2a8fc Compare November 13, 2024 15:27
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 commits instead of doing more comments. Feel free to review them or to merge directly

internal/fingerprint/fingerprint.go Show resolved Hide resolved
internal/injector/aspect/advice/code/template.go Outdated Show resolved Hide resolved
Base automatically changed from romain.marcadier/APPSEC-55160/config-loader to main November 18, 2024 14:33
RomainMuller and others added 4 commits November 18, 2024 15:47
@RomainMuller RomainMuller force-pushed the romain.marcadier/APPSEC-55160/fingerprinter branch from 5fb209e to 1e099e3 Compare November 18, 2024 14:49
@RomainMuller RomainMuller added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 899719f Nov 18, 2024
23 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/APPSEC-55160/fingerprinter branch November 18, 2024 16:49
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 114 lines in your changes missing coverage. Please review.

Project coverage is 60.91%. Comparing base (9cae407) to head (bce6597).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/fingerprint/fingerprint.go 42.85% 22 Missing and 10 partials ⚠️
internal/injector/aspect/join/function.go 0.00% 14 Missing ⚠️
internal/injector/aspect/aspect.go 0.00% 8 Missing ⚠️
internal/injector/aspect/advice/code/template.go 46.15% 6 Missing and 1 partial ⚠️
internal/injector/aspect/join/struct.go 0.00% 6 Missing ⚠️
internal/fingerprint/types.go 88.09% 5 Missing ⚠️
internal/injector/aspect/advice/call.go 42.85% 4 Missing ⚠️
internal/injector/aspect/advice/inject.go 33.33% 4 Missing ⚠️
internal/injector/aspect/join/declaration.go 0.00% 4 Missing ⚠️
internal/injector/aspect/join/package.go 0.00% 4 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   60.31%   60.91%   +0.60%     
==========================================
  Files         179      181       +2     
  Lines       12593    12702     +109     
==========================================
+ Hits         7595     7737     +142     
+ Misses       4500     4435      -65     
- Partials      498      530      +32     
Components Coverage Δ
Generators 76.72% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.94% <ø> (ø)
Toolexec Driver 70.66% <ø> (ø)
Aspects 71.50% <18.08%> (-0.39%) ⬇️
Injector 71.98% <18.08%> (-0.23%) ⬇️
Job Server 68.13% <ø> (+6.09%) ⬆️
Integration Test Suite 54.24% <ø> (ø)
Other 60.91% <40.62%> (+0.60%) ⬆️
Files with missing lines Coverage Δ
internal/injector/aspect/advice/assign.go 64.51% <50.00%> (-4.45%) ⬇️
internal/injector/aspect/advice/block.go 65.62% <50.00%> (-4.38%) ⬇️
internal/injector/aspect/advice/import.go 72.22% <0.00%> (-9.03%) ⬇️
internal/injector/aspect/advice/struct.go 54.54% <0.00%> (-2.60%) ⬇️
internal/injector/aspect/advice/wrap.go 71.79% <50.00%> (-3.89%) ⬇️
internal/injector/aspect/context/golang.go 77.14% <0.00%> (-4.68%) ⬇️
internal/injector/aspect/join/all-of.go 66.66% <0.00%> (-3.34%) ⬇️
internal/injector/aspect/join/configuration.go 80.00% <0.00%> (-5.72%) ⬇️
internal/injector/aspect/join/directive.go 86.95% <0.00%> (-3.96%) ⬇️
internal/injector/aspect/join/expression.go 78.94% <0.00%> (-4.39%) ⬇️
... and 13 more

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants