-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(goenv.GOMOD): never rely on the environment variable #384
Merged
RomainMuller
merged 18 commits into
main
from
romain.marcadier/APPSEC-55160/goenv.GOMOD-dir
Nov 12, 2024
Merged
fix(goenv.GOMOD): never rely on the environment variable #384
RomainMuller
merged 18 commits into
main
from
romain.marcadier/APPSEC-55160/goenv.GOMOD-dir
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EC-55160/enhance-pin # Conflicts: # samples/go.mod # samples/go.sum
…EC-55160/enhance-pin # Conflicts: # internal/pin/pin.go
Use `instrument_test` package for tests of the public API. This ensures all test packaging styles are in use in this package; which is a good thing for some package-loading tests.
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-55160/rework-instrument-test
branch
2 times, most recently
from
November 8, 2024 09:04
f839238
to
892a8af
Compare
…EC-55160/rework-instrument-test # Conflicts: # internal/pin/auto.go # internal/pin/gomod.go # internal/pin/pin.go # internal/pin/pin_test.go
…work-instrument-test' into romain.marcadier/APPSEC-55160/rework-instrument-test
The value of `go env GOMOD` changes depending on the working directory where the command is executed. Instead of relying on the environment variable, always spawn `go env GOMOD` in an explicitly selected directory.
RomainMuller
force-pushed
the
romain.marcadier/APPSEC-55160/goenv.GOMOD-dir
branch
from
November 12, 2024 10:02
adbbf0f
to
bd172b3
Compare
eliottness
reviewed
Nov 12, 2024
Base automatically changed from
romain.marcadier/APPSEC-55160/rework-instrument-test
to
main
November 12, 2024 11:07
eliottness
approved these changes
Nov 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 60.85% 60.86% +0.01%
==========================================
Files 174 175 +1
Lines 12341 12343 +2
==========================================
+ Hits 7510 7513 +3
+ Misses 4350 4349 -1
Partials 481 481
|
RomainMuller
deleted the
romain.marcadier/APPSEC-55160/goenv.GOMOD-dir
branch
November 12, 2024 14:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
go env GOMOD
changes depending on the working directorywhere the command is executed. Instead of relying on the environment
variable, always spawn
go env GOMOD
in an explicitly selecteddirectory.