Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use t.Cleanup() for integration tests cleanup #382

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Nov 6, 2024

Use t.Cleanup to make sure the cleanup logic is registered right after the resource is created and always gets executed when the test finishes.

@rarguelloF rarguelloF marked this pull request as ready for review November 7, 2024 11:15
@rarguelloF rarguelloF requested a review from a team as a code owner November 7, 2024 11:15
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through everything. LGTM 👍

_integration-tests/tests/pgx/pgx.go Show resolved Hide resolved
_integration-tests/tests/sql/sql.go Show resolved Hide resolved
@rarguelloF rarguelloF added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit a4ba006 Nov 7, 2024
23 checks passed
@rarguelloF rarguelloF deleted the rarguellof/refactor-cleanup branch November 7, 2024 12:20
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.66%. Comparing base (6b2ab98) to head (9f5f95e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   61.33%   60.66%   -0.67%     
==========================================
  Files         171      171              
  Lines       12020    11950      -70     
==========================================
- Hits         7372     7250     -122     
- Misses       4162     4238      +76     
+ Partials      486      462      -24     
Components Coverage Δ
Generators 76.98% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.13% <ø> (ø)
Toolexec Driver 70.64% <ø> (ø)
Aspects 71.73% <ø> (ø)
Injector 73.72% <ø> (ø)
Job Server 63.45% <ø> (-4.11%) ⬇️
Integration Test Suite 54.24% <100.00%> (-0.28%) ⬇️
Other 60.66% <100.00%> (-0.67%) ⬇️
Files with missing lines Coverage Δ
...integration-tests/tests/99designs.gqlgen/gqlgen.go 100.00% <ø> (ø)
_integration-tests/tests/aws.v1/aws.go 94.28% <ø> (-0.59%) ⬇️
_integration-tests/tests/aws.v2/base.go 93.61% <ø> (-0.51%) ⬇️
...egration-tests/tests/aws.v2/load_default_config.go 100.00% <ø> (ø)
_integration-tests/tests/aws.v2/new_config.go 100.00% <ø> (ø)
_integration-tests/tests/aws.v2/struct_literal.go 100.00% <ø> (ø)
...tegration-tests/tests/aws.v2/struct_literal_ptr.go 100.00% <ø> (ø)
_integration-tests/tests/chi.v5/chi.go 100.00% <100.00%> (ø)
...gration-tests/tests/confluent-kafka-go.v1/kafka.go 100.00% <ø> (ø)
...-tests/tests/confluent-kafka-go.v1/skip_windows.go 50.00% <ø> (+10.00%) ⬆️
... and 46 more

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants