Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support github.com/elastic/go-elasticsearch #347

Merged
merged 29 commits into from
Oct 28, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 21, 2024

Adds support for:

  • github.com/elastic/go-elasticsearch/v6
  • github.com/elastic/go-elasticsearch/v7
  • github.com/elastic/go-elasticsearch/v8

@rarguelloF rarguelloF marked this pull request as ready for review October 22, 2024 11:42
@rarguelloF rarguelloF requested a review from a team as a code owner October 22, 2024 11:42
@rarguelloF rarguelloF enabled auto-merge October 22, 2024 11:42
@rarguelloF rarguelloF added this pull request to the merge queue Oct 28, 2024
@rarguelloF rarguelloF removed this pull request from the merge queue due to a manual request Oct 28, 2024
@RomainMuller RomainMuller added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit d8a673c Oct 28, 2024
21 checks passed
@RomainMuller RomainMuller deleted the rarguellof/APPSEC-55048/go-elasticsearch branch October 28, 2024 13:04
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 86.06557% with 17 lines in your changes missing coverage. Please review.

Project coverage is 61.38%. Comparing base (7d24aff) to head (98617fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
_integration-tests/tests/go-elasticsearch/v6.go 15.00% 16 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   57.91%   61.38%   +3.46%     
==========================================
  Files         153      155       +2     
  Lines       11124     9667    -1457     
==========================================
- Hits         6443     5934     -509     
+ Misses       4213     3262     -951     
- Partials      468      471       +3     
Components Coverage Δ
Generators 78.35% <100.00%> (+1.37%) ⬆️
Instruments 88.05% <ø> (ø)
Go Driver 80.24% <ø> (+7.43%) ⬆️
Toolexec Driver 74.29% <ø> (+3.41%) ⬆️
Aspects 77.12% <ø> (+6.26%) ⬆️
Injector 77.35% <ø> (+4.21%) ⬆️
Job Server 69.81% <ø> (+5.79%) ⬆️
Integration Test Suite 51.20% <86.06%> (+2.93%) ⬆️
Other 61.38% <86.06%> (+3.46%) ⬆️
Files with missing lines Coverage Δ
_integration-tests/tests/go-elasticsearch/base.go 100.00% <100.00%> (ø)
_integration-tests/tests/go-elasticsearch/v7.go 100.00% <100.00%> (ø)
_integration-tests/tests/go-elasticsearch/v8.go 100.00% <100.00%> (ø)
_integration-tests/utils/generator/main.go 75.34% <100.00%> (+11.70%) ⬆️
_integration-tests/tests/go-elasticsearch/v6.go 15.00% <15.00%> (ø)

... and 132 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants