Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use confluent kafka image for tests #289

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Sep 23, 2024

Replace docker.redpanda.com/redpandadata/redpanda for confluentinc/confluent-local docker image for Kafka tests.

The sarama tests are currently flaking with the following error:

    ibm_sarama.go:127: 
        	Error Trace:	/home/runner/work/orchestrion/orchestrion/_integration-tests/tests/ibm_sarama/ibm_sarama.go:87
        	            				/home/runner/work/orchestrion/orchestrion/_integration-tests/tests/ibm_sarama/ibm_sarama.go:127
        	            				/home/runner/work/orchestrion/orchestrion/_integration-tests/utils/suite.go:77
        	            				/home/runner/work/orchestrion/orchestrion/_integration-tests/tests/ibm_sarama/gen_test.go:18
        	Error:      	Received unexpected error:
        	            	kafka: client has run out of available brokers to talk to: kafka: error decoding packet: message of length 1213486160 too large or too small
        	Test:       	TestIntegration_ibm_sarama
        	Messages:   	failed to create producer

We suspect it might be caused by the test starting before the container being fully ready. The confluent kafka testcontainers module seems to have smarter readiness check logic than the redpanda one, so hopefully this change solves the issue.

@rarguelloF rarguelloF marked this pull request as ready for review September 23, 2024 12:47
@rarguelloF rarguelloF requested a review from a team as a code owner September 23, 2024 12:47
@rarguelloF rarguelloF added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 1b1f5aa Sep 23, 2024
22 checks passed
@rarguelloF rarguelloF deleted the rarguellof/use-kafka-image branch September 23, 2024 13:33
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (1d46913) to head (f3d8d9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   73.80%   73.85%   +0.04%     
==========================================
  Files         145      145              
  Lines        7966     7958       -8     
==========================================
- Hits         5879     5877       -2     
+ Misses       1658     1653       -5     
+ Partials      429      428       -1     
Components Coverage Δ
Generators 76.69% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 72.81% <ø> (ø)
Toolexec Driver 70.88% <ø> (ø)
Aspects 71.95% <ø> (ø)
Injector 73.42% <ø> (ø)
Job Server 63.76% <ø> (+0.56%) ⬆️
Integration Test Suite 87.80% <100.00%> (-0.05%) ⬇️
Other 73.85% <100.00%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
_integration-tests/tests/ibm_sarama/ibm_sarama.go 82.97% <100.00%> (-2.07%) ⬇️
...ation-tests/tests/shopify_sarama/shopify_sarama.go 89.61% <100.00%> (-1.51%) ⬇️
_integration-tests/utils/testcontainers.go 95.55% <100.00%> (+2.96%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants