Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.8.1-rc.1 #267

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Conversation

nsrip-dd
Copy link
Contributor

Upgrade dd-trace-go to v1.68.0-rc.1 and release v0.8.1-rc.1

Upgrade dd-trace-go to v1.68.0-rc.1 and release v0.8.1-rc.1
@nsrip-dd nsrip-dd marked this pull request as ready for review September 10, 2024 14:46
@nsrip-dd nsrip-dd requested a review from a team as a code owner September 10, 2024 14:46
@nsrip-dd
Copy link
Contributor Author

I don't understand this "Tests / Update PR with generated files (pull_request)" failure: https://github.com/DataDog/orchestrion/actions/runs/10794368946/job/29940357716?pr=267. Is it related to the changes in this PR?

@eliottness
Copy link
Contributor

Hey @nsrip-dd , I think I know why this is breaking but this error is definitively not friendly. Please make sure all the go.mod have been updated by using find -name go.mod -execdir go mod tidy \; or equivalent. I see some changes after running it

@nsrip-dd nsrip-dd force-pushed the nick.ripley/dd-trace-go-v1.68.0-rc.1 branch from 3d2bb32 to 1eef0e9 Compare September 12, 2024 12:59
Copy link
Contributor

@eliottness eliottness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can bypass the CI if you see fit

@RomainMuller RomainMuller force-pushed the nick.ripley/dd-trace-go-v1.68.0-rc.1 branch from 3b8f212 to d34c1a9 Compare September 16, 2024 09:04
@RomainMuller RomainMuller force-pushed the nick.ripley/dd-trace-go-v1.68.0-rc.1 branch from d34c1a9 to d96cbd6 Compare September 16, 2024 09:20
@nsrip-dd
Copy link
Contributor Author

Thanks Eliott and Romain! Is this good to merge or do I need to do any other stuff to publish this release?

@RomainMuller RomainMuller added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit deedc8b Sep 17, 2024
21 checks passed
@RomainMuller RomainMuller deleted the nick.ripley/dd-trace-go-v1.68.0-rc.1 branch September 17, 2024 08:03
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.53%. Comparing base (7c3a96c) to head (87f8c97).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   62.53%   62.53%           
=======================================
  Files         102      102           
  Lines        5359     5359           
=======================================
  Hits         3351     3351           
  Misses       1666     1666           
  Partials      342      342           
Components Coverage Δ
Instruments 34.56% <ø> (ø)
Go Driver 62.92% <ø> (ø)
Toolexec Driver 66.56% <ø> (ø)
Aspects 69.99% <ø> (ø)
Injector 71.62% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants