Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improvements to the user guide #249

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

RomainMuller
Copy link
Contributor

Added:

  • Feature activation documentation (Tracer, Profiler, ASM)
  • Trace customization (//dd:span, //dd:ignore)

Removed:

  • Details from README.md, replaced with pointers to the user guide

Added:
- Feature activation documentation (Tracer, Profiler, ASM)
- Trace customization (`//dd:span`, `//dd:ignore`)

Removed:
- Details from `README.md`, replaced with pointers to the user guide
@RomainMuller RomainMuller requested a review from a team as a code owner August 27, 2024 14:52
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profiler docs look good to me. I left one question about the trace context propagation section.

docs/content/docs/custom-trace.md Outdated Show resolved Hide resolved
docs/content/docs/custom-trace.md Outdated Show resolved Hide resolved
@RomainMuller RomainMuller added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit aee181b Aug 28, 2024
22 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/profiler-doc branch August 28, 2024 12:45
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.57%. Comparing base (981f2c7) to head (4cc0071).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   62.57%   62.57%           
=======================================
  Files         101      101           
  Lines        5259     5259           
=======================================
  Hits         3291     3291           
  Misses       1627     1627           
  Partials      341      341           
Components Coverage Δ
Instruments 34.56% <ø> (ø)
Go Driver 62.92% <ø> (ø)
Toolexec Driver 65.83% <ø> (ø)
Aspects 69.97% <ø> (ø)
Injector 71.65% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants